Dmitry Eremin-Solenikov(lumag) replied on github web page:
platform/linux-generic/include/odp_buffer_internal.h
line 4
@@ -104,17 +104,10 @@ struct odp_buffer_hdr_t {
/* User area pointer */
void *uarea_addr;
- /* User area size */
Comment:
@nagarahalli Any reason why we shouldn't have it in master?
> nagarahalli wrote
> This change is done already in 2.0.
>> Dmitry Eremin-Solenikov(lumag) wrote:
>> @matiaselo ok.
>>> Matias Elo(matiaselo) wrote:
>>> Since there are currently no functions in sight to put into pool_inlines.h
>>> I would suggest not to add a new header file. If/when some pool inline
>>> function are added later on the header can be created them. Is this OK for
>>> you?
>>>> Dmitry Eremin-Solenikov(lumag) wrote:
>>>> Just wanted to have pool functions in pool header, etc.
>>>>> Matias Elo(matiaselo) wrote:
>>>>> I followed the same pattern as the packet inlines.
>>>>> _odp_packet_inline_offset_t is defined in packet_types.h.
>>>>>> Matias Elo(matiaselo) wrote:
>>>>>> pool_inlines.h would only include these two lines and looking at pool
>>>>>> API there aren't any additional functions which should be inlined. Do
>>>>>> you have a particular use case in mind for this header?
>>>>>>> Dmitry Eremin-Solenikov(lumag) wrote:
>>>>>>> And this to pool_inline_types.h.
>>>>>>>> Dmitry Eremin-Solenikov(lumag) wrote:
>>>>>>>> This should go to pool_inlines.h
https://github.com/Linaro/odp/pull/281#discussion_r149737386
updated_at 2017-11-08 17:19:57
