Matias Elo(matiaselo) replied on github web page:
platform/linux-generic/pktio/dpdk.c
line 5
@@ -1079,7 +1079,7 @@ static int dpdk_input_queues_config(pktio_entry_t
*pktio_entry,
const odp_pktin_queue_param_t *p)
{
odp_pktin_mode_t mode = pktio_entry->s.param.in_mode;
- odp_bool_t lockless;
+ uint8_t lockless;
Comment:
While packing the pkt_dpdk_t struct I changed pkt_dpdk_t.lockless_rx and
pkt_dpdk_t.lockless_tx to uint8_t. I'm using the same type here.
> muvarov wrote
> why is that needed?
>> Dmitry Eremin-Solenikov(lumag) wrote:
>> This is not planned untill TigerMoth.
>>> nagarahalli wrote
>>> It is about 2.0 merge to master, it will happen sometime in the future.
>>>> Dmitry Eremin-Solenikov(lumag) wrote:
>>>> @nagarahalli Any reason why we shouldn't have it in master?
>>>>> nagarahalli wrote
>>>>> This change is done already in 2.0.
>>>>>> Dmitry Eremin-Solenikov(lumag) wrote:
>>>>>> @matiaselo ok.
>>>>>>> Matias Elo(matiaselo) wrote:
>>>>>>> Since there are currently no functions in sight to put into
>>>>>>> pool_inlines.h I would suggest not to add a new header file. If/when
>>>>>>> some pool inline function are added later on the header can be created
>>>>>>> them. Is this OK for you?
>>>>>>>> Dmitry Eremin-Solenikov(lumag) wrote:
>>>>>>>> Just wanted to have pool functions in pool header, etc.
>>>>>>>>> Matias Elo(matiaselo) wrote:
>>>>>>>>> I followed the same pattern as the packet inlines.
>>>>>>>>> _odp_packet_inline_offset_t is defined in packet_types.h.
>>>>>>>>>> Matias Elo(matiaselo) wrote:
>>>>>>>>>> pool_inlines.h would only include these two lines and looking at
>>>>>>>>>> pool API there aren't any additional functions which should be
>>>>>>>>>> inlined. Do you have a particular use case in mind for this header?
>>>>>>>>>>> Dmitry Eremin-Solenikov(lumag) wrote:
>>>>>>>>>>> And this to pool_inline_types.h.
>>>>>>>>>>>> Dmitry Eremin-Solenikov(lumag) wrote:
>>>>>>>>>>>> This should go to pool_inlines.h
https://github.com/Linaro/odp/pull/281#discussion_r149886864
updated_at 2017-11-09 08:01:16
