Bill Fischofer(Bill-Fischofer-Linaro) replied on github web page:
example/ipsec_api/odp_ipsec_sa_db.c
line 1
@@ -0,0 +1 @@
+../ipsec/odp_ipsec_sa_db.c
Comment:
Checkpatch doesn't like this construct:
```
WARNING: adding a line without newline at end of file
#1751: FILE: example/ipsec_api/odp_ipsec_fwd_db.c:1:
+../ipsec/odp_ipsec_fwd_db.c
```
Missing newline?
> Bill Fischofer(Bill-Fischofer-Linaro) wrote:
> Similar checkpatch issue here:
> ```
> WARNING: else is not generally useful after a break or return
> #859: FILE: example/ipsec_api/odp_ipsec.c:667:
> + return PKT_POSTED;
> + } else {
> ```
>> Bill Fischofer(Bill-Fischofer-Linaro) wrote:
>> Checkpatch complains about this construct. Prefers no else after return:
>> ```
>> WARNING: else is not generally useful after a break or return
>> #795: FILE: example/ipsec_api/odp_ipsec.c:603:
>> + return PKT_POSTED;
>> + } else {
>> ```
https://github.com/Linaro/odp/pull/340#discussion_r157371840
updated_at 2017-12-17 15:56:52
