Bill Fischofer(Bill-Fischofer-Linaro) replied on github web page:
example/ipsec_api/odp_ipsec_stream.c
line 1
@@ -0,0 +1 @@
+../ipsec/odp_ipsec_stream.c
Comment:
```
WARNING: adding a line without newline at end of file
#2012: FILE: example/ipsec_api/odp_ipsec_stream.c:1:
+../ipsec/odp_ipsec_stream.c
```
> Bill Fischofer(Bill-Fischofer-Linaro) wrote:
> Missing newline here too.
> ```
> WARNING: adding a line without newline at end of file
> #2020: FILE: example/ipsec_api/odp_ipsec_stream.h:1:
> +../ipsec/odp_ipsec_stream.h
> ```
>> Bill Fischofer(Bill-Fischofer-Linaro) wrote:
>> Checkpatch seems confused here. Is it expecting a .sh suffix? Any thoughts
>> on this @muvarov?
>> ```
>> ERROR: do not set execute permissions for source files
>> #1770: FILE: example/ipsec_api/odp_ipsec_run_ah_in
>> ```
>> The rest of the shell files are similarly flagged.
>>> Bill Fischofer(Bill-Fischofer-Linaro) wrote:
>>> Also here:
>>> ```
>>> WARNING: adding a line without newline at end of file
>>> #1767: FILE: example/ipsec_api/odp_ipsec_misc.h:1:
>>> +../ipsec/odp_ipsec_misc.h
>>> ```
>>>> Bill Fischofer(Bill-Fischofer-Linaro) wrote:
>>>> Similar issues here. Missing newline?
>>>> ```
>>>> WARNING: adding a line without newline at end of file
>>>> #1759: FILE: example/ipsec_api/odp_ipsec_fwd_db.h:1:
>>>> +../ipsec/odp_ipsec_fwd_db.h
>>>> ```
>>>>> Bill Fischofer(Bill-Fischofer-Linaro) wrote:
>>>>> Checkpatch doesn't like this construct:
>>>>> ```
>>>>> WARNING: adding a line without newline at end of file
>>>>> #1751: FILE: example/ipsec_api/odp_ipsec_fwd_db.c:1:
>>>>> +../ipsec/odp_ipsec_fwd_db.c
>>>>> ```
>>>>> Missing newline?
>>>>>> Bill Fischofer(Bill-Fischofer-Linaro) wrote:
>>>>>> Similar checkpatch issue here:
>>>>>> ```
>>>>>> WARNING: else is not generally useful after a break or return
>>>>>> #859: FILE: example/ipsec_api/odp_ipsec.c:667:
>>>>>> + return PKT_POSTED;
>>>>>> + } else {
>>>>>> ```
>>>>>>> Bill Fischofer(Bill-Fischofer-Linaro) wrote:
>>>>>>> Checkpatch complains about this construct. Prefers no else after return:
>>>>>>> ```
>>>>>>> WARNING: else is not generally useful after a break or return
>>>>>>> #795: FILE: example/ipsec_api/odp_ipsec.c:603:
>>>>>>> + return PKT_POSTED;
>>>>>>> + } else {
>>>>>>> ```
https://github.com/Linaro/odp/pull/340#discussion_r157372048
updated_at 2017-12-17 15:56:52
