On Dec 22, 2005, at 7:56 AM, Andreas Fester wrote:
Hi,
the attached patch fixes the UTF8 build on unix.
simpledateformat.cpp/h:
- new typedef for std::basic_string<localechar>
- Moved PatternToken to the .cpp file. This allows
PatternToken::format to take a LocaleString which
is necessary because LocaleString and LogString
are not necessarily compatible when compiled with
logchar=UTF8.
logstream.cpp/stream.h:
- Necessary changes to compile the test scenarios with
logchar=utf8.
If there are no objections, I will commit those.
Thanks & Best Regards,
Andreas
What was the nature of the compile failures? Was it on a specific
platform or had their been changes that introduced the failure? Gump
may no longer be building log4cxx since apr-util has had a build
failure for a month.
I don't think that SimpleDateFormat is open for user added patterns
like PatternLayout is and so would not need to expose the
PatternToken class in the header file. Seems like a good change to
me and I don't recall why I did it like that in the first place.
