Guten Tag Robert Middleton, am Donnerstag, 7. Juli 2016 um 15:26 schrieben Sie:
> I have figured out why this test is failing on my machine, I don't > have the 'zip' utility installed by default. Good to hear it was that simple. ;-) > Due to how APR works as well, we get back an exit code of 255 > from the child process in the apr_proc_wait call in > zipcompressaction.cpp. Normally, this should be ENOENT(or > APR_ENOENT), but APR returns -1 if any of the exec calls fail. I'm not sure I understand this... When is 255/-1 returned in your case, with missing zip or if it's available and succeeded? Because you are writing of "exec calls fail". Did you test what your zip utility returns if you invoked it on a shell? I wonder if it has a reason that the exit status is not checked, maybe it didn't work and is just not documented? > 2. If return code is 255, throw exception from ZipCompressAction::execute If we check the exit status, I prefer this one, because an exception is thrown already for any other problem as well. Like just starting the command. A failing command is no difference in my mind. Mit freundlichen Grüßen, Thorsten Schöning -- Thorsten Schöning E-Mail: thorsten.schoen...@am-soft.de AM-SoFT IT-Systeme http://www.AM-SoFT.de/ Telefon...........05151- 9468- 55 Fax...............05151- 9468- 88 Mobil..............0178-8 9468- 04 AM-SoFT GmbH IT-Systeme, Brandenburger Str. 7c, 31789 Hameln AG Hannover HRB 207 694 - Geschäftsführer: Andreas Muchow
