Nice job, Bruno.

Here are a few tips you might consider to widen the appeal of your
Appender.

- at the bottom of your append method you directly access the
 throwableInformation attribute of the LoggingEvent object.
 I'm not sure how you made this work on your machine, but you
 should use the provided public getter method to obtain this
 value.

- you might want to check that layout is not null before using
  it (in the append method).  Granted, one expects it to be
  set in order to make things work properly.  But the result
  should be more informative than NullPointerException.

I wonder how I could write one of these for Windoze. :)

Paul Glezen
[EMAIL PROTECTED]


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to