On Sunday 18 February 2001 10:51, you wrote:
> Nice job, Bruno.
>
Thanks.
> Here are a few tips you might consider to widen the appeal of your
> Appender.
>
> - at the bottom of your append method you directly access the
> throwableInformation attribute of the LoggingEvent object.
> I'm not sure how you made this work on your machine, but you
> should use the provided public getter method to obtain this
> value.
>
I copied this directly from the FileAppender, so I guess it is ok?
> - you might want to check that layout is not null before using
> it (in the append method). Granted, one expects it to be
> set in order to make things work properly. But the result
> should be more informative than NullPointerException.
>
OK, I'll change that.
I'm also planning to make the colors configurable through the
log4j.properties file, which I will do as soon as I find the time to figure
it out.
> I wonder how I could write one of these for Windoze. :)
I have no idea, maybe someone else on the list knows how?
Bruno Dumon.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
