I have looked at your code. You should definitely add yourself as an author. However,
before I can commit the change to the CVS repository I need to throughly understand
the code which I currently don't. Some extra documentation would not hurt. In
particular, how do you know that in customReadObject(ObjectInputStream ois)
method invoking ois.readFields() will work? Is this documented somewhere?
private void customReadObject( ObjectInputStream ois )
throws IOException, ClassNotFoundException {
final ObjectInputStream.GetField oisFields = ois.readFields();
...
}
Could you share code that allows you to test that you can write a log4j 1.1.3
LoggingEvent and read it back with 1.2? I suppose writing 1.2 and reading it back in
1.1.3 will not work. Otherwise, I quite like the idea of the code. IMHO, you should
consider writing a javaworld article.
I would not worry about startTime as long as the relative time between events
generated on the same client is correct (which it will be.)
Regards, ceki
At 23:19 18.11.2001 -0500, you wrote:
>I'm pretty happy with the new version posted at
>http://traxel.com/tools/LoggingEvent.java
>
>It's now reading 1.1.3 and 1.2, and deserialization
>has been refactored to a satisfactory level.
>
>Known Issues:
>
> - It has not been rigorously tested.
>
> - startTime is static, so when you serialize,
> then compare startTime to timeStamp you get
> a meaningless number (startTime is coming
> from the server, timeStamp is coming from
> the client). This could be solved by making
> startTime an instance parameter, and initializing
> it to application start time in the constructor
> (have a class parameter systemStartTime).
> Then readObject could simply overwrite the
> instance parameter with the serialized value.
>
> This is, of course, assuming that the objective
> is to be able to tell how long into it's life
> the application was when the log was generated.
>
>
>--
>To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]>
>For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
--
To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
