> However, do you really need it? Please answer by just > yes or no as I would like to discover the reason for > myself by studying your code once again.
As currently written, yes. Stop now if you want to look at the code to see why or keep reading if you want my explanation. <spoiler> The Watchdog should not assume that a URL is sufficient to accessing the configuration data. It depends on the subclass to access the configuration data (presumeably from the element it is watching) in whatever way is appropriate and provide it as an InputStream. The data might come from a file, a url, or something completely different. The Configurator interface only supports a doConfigure method that takes a url. It is my opinion that an InputStream is more generic than a URL, and all configurators should be able to support InputStream. Unless I am missing something fundamental here. </spoiler> -Mark -----Original Message----- From: Ceki Gülcü [mailto:[EMAIL PROTECTED]] Sent: Tuesday, January 15, 2002 12:30 PM To: Log4J Developers List Subject: RE: CODE: Watchdog, FileWatchdog, HTTPWatchdog At 12:39 14.01.2002 -0800, Mark Womack wrote: >Also, do you think it is possible to add the doConfigure(InputStream) method >to the Configurator interface? Would you consider that method "common" to >all configurators? If I can assume the interface has this method, then I >would not need to use reflection to find it. Just a thought. I know you >want to keep the Configurator interface as simple and lean as possible, but >it seems to me that an InputStream is about as common as one can get. Adding the doConfigure(InputStream) is easy. However, do you really need it? Please answer by just yes or no as I would like to discover the reason for myself by studying your code once again. (I don't see the reason for the moment.) Cheers, Ceki -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]> -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
