Hi Ceki, I posted a patch via Bugz that fixed Checkstyle issues, but had not run Jalopy (didn't know what it was! :) . After I had finished, there were only 2 checkstyle errors. Somehow not all the changes have gone through with the applying of the patch (did a lot of JavaDoc cleanup) as checkstyle is now reporting 24 errors.
In the long run, I don't mind if Jalopy is run by someone, and then I can go ahead and tidy up an remaining checkstyle issues that Jalopy doesn't address. Probably best to check with Mark/Oliver if they have anything actively working on. Sorry if I've stuffed something up. cheers, and welcome back from your holiday. [Incidently, how do I type the umlaut in your name?? How does one pronounce it? :) I was given a very boring name, and I'm jealous!] Paul Smith -----Original Message----- From: Ceki Gülcü To: [EMAIL PROTECTED] Sent: 3/18/03 8:44 PM Subject: Applying Jalopy? Hi all, I have updated my local files from our CVS rep and then set up and ran jalopy with the following command: LOG4J_HOME/ > ant runJalopy This resulted in a message stating that Jalopy was run on 24 (or so) files. I then ran CVS update: LOG4J_HOME/ > cvs up [snip] M src/java/org/apache/log4j/chainsaw/ChainsawAppender.java M src/java/org/apache/log4j/chainsaw/ChainsawViewer.java M src/java/org/apache/log4j/chainsaw/DefaultViewer.java M src/java/org/apache/log4j/chainsaw/DetailPanel.java M src/java/org/apache/log4j/chainsaw/LoadXMLAction.java M src/java/org/apache/log4j/chainsaw/Log4JConfigurationFinder.java M src/java/org/apache/log4j/chainsaw/Main.java M src/java/org/apache/log4j/chainsaw/MyTableColumnModel.java M src/java/org/apache/log4j/chainsaw/MyTableModel.java M src/java/org/apache/log4j/chainsaw/PreferencesDialog.java M src/java/org/apache/log4j/chainsaw/RecentFilesMenu.java M src/java/org/apache/log4j/chainsaw/Start.java M src/java/org/apache/log4j/chainsaw/XMLFileHandler.java [snip] M src/java/org/apache/log4j/plugins/Plugin.java M src/java/org/apache/log4j/plugins/PluginRegistry.java M src/java/org/apache/log4j/plugins/PluginSkeleton.java M src/java/org/apache/log4j/plugins/Receiver.java [snip] Thus, running jalopy seemed to have modified a number of files. Diffing on src/java/org/apache/log4j/chainsaw/ChainsawAppender.java showed that japoly made some formatting changes. Diffing on src/java/org/apache/log4j/plugins/Plugin.java showed the addition of the Apache license at the top plus minor formatting changes. Similarly for the other files. I am assuming that the latest commits did not go through japoly? If not, was that because of involuntary omission or on the contrary deliberate? I am just trying to understand and catch up. -- Ceki --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
