Had an issue yesterday with Chainsaw loading duplicate events.

Our cyclicbuffer stores loggingevents, and was performing a 'contains'
check on the list to prevent duplicate events from being added
(duplicates could exist if an xml log file was loaded twice or if the
events came from jdk1.4 logging, for example).

Of course, the contains check always returned false since the receiver
reconstructs the loggingevent from the xml representation and
LoggingEvent doesn't implement equals.

I worked around it by storing a hashset of the event's ID in the model.
Duplicates show up if the events were loaded from xml or over the wire
from jdk1.4 logging.

I know we've discussed this on the list before, but could we resolve
this?  If we plan on supporting the ability to add LoggingEvents to a
collection, we need to implement equals and hashCode.

As I looked at it, one of the more prominent issues was the
throwableinfo either being a throwable or a string[].

Opinions?  Can we get resolution on this issue?

Thanks,

Scott

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to