> 1) It is the string representation which we output anyway. (Thus, the cost
> of conversion to string[] will be eventually paid anyhow).
If it is not sent to an appender it won't (will it?), but of course
stacktraces are such an important thing that it's highly likely to be
appended, so you are right.
> 2) More importantly, logging events containing exceptions are rare, so
> speed is not an issue in the first place!
>
>
> Actually, I think
>
> public ThrowableInformation(Throwable throwable) {
> this.throwable = throwable;
> }
>
> should be changed to:
>
> public ThrowableInformation(Throwable throwable) {
> rep = getThrowableStrRep(throwable);
> }
So we would always store just the stringrep, and we would remove the
need to hold the throwable? If so, +1
cheers,
Paul
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
