Thank for this patch. It is appreciated. Unfortunately, I don't think we could include it for the following reasons. Joseph,
First, the rolling appenders have been rewritten. See o.a.l.rolling package in log4j cvs. Second, it is not good practice to hide threads within appenders.
Have you considered sending a heartbeat log at the right time? You can use the JDK java.util.Timer class to schedule hearbeat logs. I think many application containers offer services to schedule certain actions.
At 05:24 PM 12/9/2003 +0100, Walid Joseph Gedeon wrote:
Hello all!
This is about the fact that the DailyRollingAppender does not roll at the top-of-the-period that is set, but instead at the first log after that time has passed. This issue is the one listed in bug 10560 (DailyRollingAppender does not roll each period). I thought I might lay this here to check for opinions.
I propose a small fix to that situation: Attached is an extension of DailyRollingAppender that has an extra (optional) parameter that can be set to force the appender to rollover at the top of the set period. I called it TimeBasedRollingFileAppender to not call it DailyRollingAppenderWithTheOptionToForceRollover) but I am not specially attached to that name :D
The idea is to either extend the current DailyRolling with the introduced option, or to include this appender along (maybe then finding it a better name :)
If it is indeed a useful and acceptable update, please go ahead and include it (I believe CVS access is read-only to common mortals)
What do you think? Comments, suggestions?
Thank!
-jo
-- Ceki Gülcü
For log4j documentation consider "The complete log4j manual"
ISBN: 2970036908 http://www.qos.ch/shop/products/clm_t.jsp
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
