Thank you for your reply, Ceki. > First, the rolling appenders have been rewritten. See o.a.l.rolling > package in log4j cvs. I will refer to the cvs sources (so far I was based on the sources in the jar). Do the re-written appenders address this issue? I'll probably self-answer that by reading the sources.
> Second, it is not good practice to hide threads > within appenders. What is the reason bahind this? The thread used is a daemon thread, so it will not hang the system... is it because of using up an additional thread per instance? In all situations, a common timer can be used to which this appender would register for events. > Have you considered sending a heartbeat log at the right time? You can > use the JDK java.util.Timer class to schedule hearbeat logs. I think > many application containers offer services to schedule certain > actions. That would surely solve the problem, however, it would require the system to have knowledge of the logging configuration (the choices of the appenders and the setting of the top of the period times are set in an external properties file). We would like to keep this configuration external to the code, as it is a very usefull feature. I am afraid the heartbeat log is not a good solution in our case unfortunately... -jo > At 05:56 PM 12/9/2003 +0100, Ceki Gülcü wrote: > > Thank for this patch. It is appreciated. Unfortunately, I don't think > we could include it for the following reasons. > Joseph, > > First, the rolling appenders have been rewritten. See o.a.l.rolling > package in log4j cvs. Second, it is not good practice to hide threads > within appenders. > > Have you considered sending a heartbeat log at the right time? You can > use the JDK java.util.Timer class to schedule hearbeat logs. I think > many application containers offer services to schedule certain > actions. > > > At 05:24 PM 12/9/2003 +0100, Walid Joseph Gedeon wrote: >>Hello all! >> >> This is about the fact that the DailyRollingAppender does not roll >> at >>the top-of-the-period that is set, but instead at the first log after >>that time has passed. >> This issue is the one listed in bug 10560 (DailyRollingAppender does >>not roll each period). I thought I might lay this here to check for >>opinions. >> >> I propose a small fix to that situation: Attached is an extension of >>DailyRollingAppender that has an extra (optional) parameter that can >>be set to force the appender to rollover at the top of the set period. >> I called it TimeBasedRollingFileAppender to not call it >>DailyRollingAppenderWithTheOptionToForceRollover) but I am not >>specially attached to that name :D >> >> The idea is to either extend the current DailyRolling with the >>introduced option, or to include this appender along (maybe then >>finding it a better name :) >> >> If it is indeed a useful and acceptable update, please go ahead and >>include it (I believe CVS access is read-only to common mortals) >> >> What do you think? Comments, suggestions? >> >>Thank! >> >>-jo > > -- > Ceki Gülcü > > For log4j documentation consider "The complete log4j manual" > ISBN: 2970036908 http://www.qos.ch/shop/products/clm_t.jsp > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
