My recent commits don't have anything to do with this issue. They certainly don't extend the Configurator api to include a getErrorList method or a doConfigure method that takes a list to put errors into.

Just from this description, it appears that only JoranConfigurator has this "stateful" feature. Maybe a better way to handle this would be through a callback mechanism. Then the client could do whatever it pleases. Store it in a list for later use, whatever.

If this is a feature one would want for all Configurators, the interface would need to be updated to include the method to register the callback.

-Mark

----- Original Message ----- From: "Curt Arnold" <[EMAIL PROTECTED]>
To: "Log4J Developers List" <[EMAIL PROTECTED]>
Sent: Wednesday, December 08, 2004 9:49 PM
Subject: Make Configurators stateless again



I mentioned this a couple of days ago in http://nagoya.apache.org/eyebrowse/ReadMsg?listName=log4j- [EMAIL PROTECTED]&msgNo=8225. JoranConfigurator had changed the configuration pattern from:

JoranConfigurator.configure(filename)

to

JoranConfigurator config = new JoranConfigurator();
config.doConfigure(filename);
List errors = config.getErrorList();

Mark Womack's recent commits suggest that this is being extended to the other configurators.

Making the configurator's hold on to the error list seems like a bad idea. It would be much cleaner to keep the configurator's stateless by allowing the user to pass in a List to receive configuration errors if they desire them or null if they don't care.


--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]





--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]



Reply via email to