At 09:37 AM 12/17/2004, Scott Deboy wrote:
I'm a bit confused.
Originally, this thread started with the bug discovered by Curt where
if you did not have a build.properties file and invoked 'ant jar',
you'd get a log4j-chainsaw.jar file containing .html .jpg files but no
.class files because the compilation of chainsaw classes would be
skipped but log4j-chainsaw.jar would still be created.
A practically empty log4j-chainsaw.jar file is hardly comparable to
a log4j.jar file missing JMS or SMTP support.
Is that perhaps the source of the confusion?
In the current build script:
If JavaMail is missing from the classpath, the build doesn't compile
SMTPAppender - and creates a log4j jar without SMTPAppender. Also, the
person compiling isn't notified that SMTPAppender won't be included in the jar.
Indeed.
The JMS dependency has the same effect on JMSAppender - JMSAppender is not
compiled but the log4j jar is still created.
Indeed.
My change to exclude ORO-dependent classes seemed to follow this same
pattern - create a chainsaw jar without the ORO-dependent classes.
Yes.
I'm not sure what I need to change in order to treat the ORO dependency
the same as we do mail and jms. From my point of view, my change to the
build is consistent with how we handle the other non-fatal but missing
dependencies (everything except jndi).
Yes.
Would you like me to change the build so that a missing ORO jar prevents
compilation or creation of log4j or chainsaw jars? If so, should we do
the same for the other dependencies (jms, mail, etc.)?
Being able to generate a functional log4j.jar just using the JDK is a
good thing. So please do not make the creation of log4j.jar
conditional on the presence of jms.jar or mail.jar.
What I suggested in my previous message was for you to move rules/*
varia/LogFilePatternReceiver*.java, and varia/ExpressionFilter.java
to log4j.jar instead of chainsaw.
Scott
--
Ceki Gülcü
The complete log4j manual: http://qos.ch/log4j/
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
