DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT <http://issues.apache.org/bugzilla/show_bug.cgi?id=39963>. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=39963 ------- Additional Comments From [EMAIL PROTECTED] 2007-01-29 13:20 ------- Comments: 1. Name the appender HibernateAppender. Names need to be short to make things easier on users. 2. Code and comments need to be in English and code formatted in the Log4J style, e.g. 2-space indent. 3. Test needs to be a JUnit test. 4. I think it's a fairly large number of files for what it does. E.g. DBAppender fits into a single class. Why can't this? Your contribution is about 10-20 files. Suggestions: 1. Create an appender that obatains the Hibernate session from JNDI or from a factory. Supply a simple factory. 2. I don't see why LoggingEvent couldn't be rendered using an .hbxml? Thanks for the contribution. Hopefully somebody can use this as a basis for a better integrated Log4j appender. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
