On Dec 13, 2008, at 10:02 AM, Curt Arnold wrote:


On Dec 13, 2008, at 3:09 AM, Ralph Goers wrote:


On Dec 12, 2008, at 11:59 PM, Scott Deboy wrote:

Which logback features?  Are they a part of SLF4j's API?


A combination. I needed Markers and I've added some minor stuff to the SLF4J extensions. What I really needed were the TurboFilters in Logback. Take a look at DynamicThresholdFilter (and note the authors names). Also, the stack trace support in Log4j was really awful. Curt recently improved it as best he can while still supporting ancient JDKs.


Are there Bugzilla issues for these?  If not, please create them.

They were added as LOG4J2-17 and LOG4J2-18. They seemed more appropriate to target for 2.0.


As for TurboFilters, it looks like this is a hierarchy-wide filter that can be evaluated prior to creating the LoggingEvent (which is expensive). I'd like to avoid adding a new concept, but could see that a new interface that could be used to advertise a filter can make a preliminary determination prior to LoggingEvent creation. This could go in log4j 1.x but has to go into the core, not a companion.

I've never been comfortable with Markers since I've never seen a clear definition of the problem they are trying to solve. They were just introduced as a completed design without any public discussion of the motivating problems which may have lead to a different solution. I'd love to see a generic Bugzilla entry that said "We need a solution for this use case or use cases" and not "We need markers".You

You can see one small example if you look at XLogger is SLF4J's extension subproject. Both entry and exit are at the trace level. The marker allows them to be differentiated from other trace events so that Appenders can deal with them in a special way if desired. When used in combination with a TurboFilter it makes adding an entry and exit to virtually every method cost almost nothing when the FLOW marker is filtered out. But other trace events might still be allowed. Markers are also useful if you want to use the logging framework for audit logging. In short, they let you treat your logging events at a much more granular level.

Ralph

---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
For additional commands, e-mail: log4j-dev-h...@logging.apache.org

Reply via email to