+1

Also, how about some standard code formatting, either for Intellij/Eclipse or a build component that we can run to reformat prior to checkin?  For instance, trimming line endings and using standard braces makes diffs easier to read, as only relevant changes show up.  We'd probably want to reformat the whole source tree once with formatting-only changes so that real changes are easily distinguishable moving forward.

Of course the challenge is settling on a code formatting style that everyone agrees upon and that is readily available to use by everyone, including non-committers and those using various IDEs.


Jake

On Sun, 27 May 2012 09:26:24 -0400
 Gary Gregory <[email protected]> wrote:
Hi All:

As I am navigating the 1.x source, I see a lot of odd formatting because
sometimes spaces are used and sometimes tabs are used, even within the same
method.

I propose we fix that. Thoughts?

If we fix it, what should the conversion from tabs to spaces be? 4 OK?

Thank you,
Gary

--
E-Mail: [email protected] | [email protected]
JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0
Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to