On Mon, May 28, 2012 at 4:24 PM, Gary Gregory <[email protected]> wrote: > On Sun, May 27, 2012 at 12:48 PM, Christian Grobmeier <[email protected]> > wrote: >> >> On Sun, May 27, 2012 at 4:18 PM, Jacob Kjome <[email protected]> wrote: >> > >> > +1 >> > >> > Also, how about some standard code formatting, either for >> > Intellij/Eclipse >> > or a build component that we can run to reformat prior to checkin? For >> > instance, trimming line endings and using standard braces makes diffs >> > easier >> > to read, as only relevant changes show up. We'd probably want to >> > reformat >> > the whole source tree once with formatting-only changes so that real >> > changes >> > are easily distinguishable moving forward. >> > >> > Of course the challenge is settling on a code formatting style that >> > everyone >> > agrees upon and that is readily available to use by everyone, including >> > non-committers and those using various IDEs. >> >> +1 on everything you said. >> >> The only drawback is if one wants to look into svn history. Then it is >> a bit problematic to match the old code against the new formatting. >> But I consider this a low risk, the benefits of a good formatting are >> worth much. >> >> To ensure a proper style one could use Checkstyle. > > > OK, sounds good. How about I start with using the same checkstyle as for > v2.0? I have that set up in my local sandbox and it does give a long list, > so that's a start before an IDE-level format operation.
That's fine for me. > (Ralph?) What IDE and settings where used to format v2.0? Why not share that > in SVN? For example in ide/format/eclipse/3.7 IntelliJ user here, hopefully there is some kind of porting tool avail :) Cheers! > > Gary > >> >> >> >> > >> > Jake >> > >> > >> > On Sun, 27 May 2012 09:26:24 -0400 >> > Gary Gregory <[email protected]> wrote: >> >> >> >> Hi All: >> >> >> >> As I am navigating the 1.x source, I see a lot of odd formatting >> >> because >> >> sometimes spaces are used and sometimes tabs are used, even within the >> >> same >> >> method. >> >> >> >> I propose we fix that. Thoughts? >> >> >> >> If we fix it, what should the conversion from tabs to spaces be? 4 OK? >> >> >> >> Thank you, >> >> Gary >> >> >> >> -- >> >> E-Mail: [email protected] | [email protected] >> >> JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0 >> >> Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK >> >> >> >> Blog: http://garygregory.wordpress.com >> >> Home: http://garygregory.com/ >> >> Tweet! http://twitter.com/GaryGregory >> > >> > >> > >> > --------------------------------------------------------------------- >> > To unsubscribe, e-mail: [email protected] >> > For additional commands, e-mail: [email protected] >> > >> >> >> >> -- >> http://www.grobmeier.de >> https://www.timeandbill.de >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: [email protected] >> For additional commands, e-mail: [email protected] >> > > > > -- > E-Mail: [email protected] | [email protected] > JUnit in Action, 2nd Ed: http://bit.ly/ECvg0 > Spring Batch in Action: http://bit.ly/bqpbCK > > Blog: http://garygregory.wordpress.com > Home: http://garygregory.com/ > Tweet! http://twitter.com/GaryGregory -- http://www.grobmeier.de https://www.timeandbill.de --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
