On Thu, Sep 27, 2012 at 9:51 PM, Ralph Goers <[email protected]> wrote: > For variable naming I have followed the default checkstyle rules. To be > honest, I can't recall seeing a variable before where the first letter was > capitalized and the rest of it wasn't. I'd have to look at the Sun naming > guidelines or other references such as effective Java to see if that is a > recommended practice.
+1 I really dislike uppercasing the first letter of a variable - static or not > > Ralph > > > > > > On Sep 27, 2012, at 10:52 AM, Gary Gregory wrote: > > In v2 trunk, I see decls like: > > private static LoggerContextFactory factory; > > Which in my world should be: > > private static LoggerContextFactory Factory; > > As it is, it may not be possible to tell a static from an instance variable > (unless the ivar is prefixed with "this.") > > For example, it is not possible with > org.apache.logging.log4j.AbstractLoggerTest.currentEvent > > This makes groking the code harder. > > Thoughts? > > Gary > > -- > E-Mail: [email protected] | [email protected] > JUnit in Action, 2nd Ed: http://bit.ly/ECvg0 > Spring Batch in Action: http://bit.ly/bqpbCK > Blog: http://garygregory.wordpress.com > Home: http://garygregory.com/ > Tweet! http://twitter.com/GaryGregory > > -- http://www.grobmeier.de https://www.timeandbill.de --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
