For reference - http://www.oracle.com/technetwork/java/javase/documentation/codeconventions-135099.html#367
Ralph On Sep 27, 2012, at 2:35 PM, Ralph Goers wrote: > As I said, this is the first time I have ever seen the first variation. I am > only familiar with the last two. Whenever I see a token starting with a > capital letter it represents a class or interface name. > > I'm not objecting because I'm not willing to consider it (although with my > IDE what you are requesting provides no value) but because I'm not familiar > with anyone else doing it. Can you point to any guidelines online that > recommend this? Can you confirm that checkstyle can be configured to support > this. If so, and no one objects, then I don't particularly care. I just > don't want these changes made and then we have to deal with piles of > checkstyle errors or potential developers who are questioning why we are > being different. > > By the way - you do know that Jetbrains will give you a free license for > IntelliJ just by telling them what ASF projects you work on - ;-) > > Ralph > > > On Sep 27, 2012, at 2:20 PM, Gary Gregory wrote: > >> There are three cases: static, final static, and instance. >> >> Usually they each get a visual cue in plain text as Static, FINAL_STATIC and >> instance. >> >> Gary >> >> On Sep 27, 2012, at 16:02, Paul Benedict <[email protected]> wrote: >> >>> I think Ralph is right. You are either doing UPPERCASE for constants or >>> camelCase for non-constant values. >>> >>> Paul >>> >>> On Thu, Sep 27, 2012 at 2:51 PM, Ralph Goers <[email protected]> >>> wrote: >>> For variable naming I have followed the default checkstyle rules. To be >>> honest, I can't recall seeing a variable before where the first letter was >>> capitalized and the rest of it wasn't. I'd have to look at the Sun naming >>> guidelines or other references such as effective Java to see if that is a >>> recommended practice. >>> >>> Ralph >>> >>> >>> >>> >>> On Sep 27, 2012, at 10:52 AM, Gary Gregory wrote: >>> >>>> In v2 trunk, I see decls like: >>>> >>>> private static LoggerContextFactory factory; >>>> >>>> Which in my world should be: >>>> >>>> private static LoggerContextFactory Factory; >>>> >>>> As it is, it may not be possible to tell a static from an instance >>>> variable (unless the ivar is prefixed with "this.") >>>> >>>> For example, it is not possible with >>>> org.apache.logging.log4j.AbstractLoggerTest.currentEvent >>>> >>>> This makes groking the code harder. >>>> >>>> Thoughts? >>>> >>>> Gary >>>> >>>> -- >>>> E-Mail: [email protected] | [email protected] >>>> JUnit in Action, 2nd Ed: http://bit.ly/ECvg0 >>>> Spring Batch in Action: http://bit.ly/bqpbCK >>>> Blog: http://garygregory.wordpress.com >>>> Home: http://garygregory.com/ >>>> Tweet! http://twitter.com/GaryGregory >>> >>> >
