Sure it's not a showstopper. +1 with:
Apache Maven 3.2.2 (45f7c06d68e745d05611f7fd14efb6594181933e; 2014-06-17T09:51:42-04:00) Maven home: C:\Java\apache-maven-3.2.2 Java version: 1.7.0_60, vendor: Oracle Corporation Java home: C:\Program Files\Java\jdk1.7.0_60\jre Default locale: en_US, platform encoding: Cp1252 OS name: "windows 7", version: "6.1", arch: "amd64", family: "windows" I would rather have seen a re-spin and RC3 but the code is acceptable as is with the notion that log4-core is not part of the public API. Gary On Tue, Jul 15, 2014 at 7:42 PM, Remko Popma <rem...@yahoo.com> wrote: > I'll defer to the RM but if the issue itself is not a showstopper then I > don't see how the paperwork for that issue could be a showstopper. > > We can update the Jira ticket to note that the full fix isn't in 2.0 and > add another entry for 703 in the 2.0.1 or 2.1 release notes, saying that it > is now fully fixed. > > If we fail this release for any reason we should just fix the problem and > vote for 2.0-GA-rc2, not have another RC, IMO. > > Sent from my iPhone > > On 2014/07/16, at 6:51, Gary Gregory <garydgreg...@gmail.com> wrote: > > How do we propose to deal with the fact that the changes.xml documents 703 > as fixed when it is not? Leave it as a known bug in 2.0 or fix it and roll > another RC? > > Gary > > > On Tue, Jul 15, 2014 at 6:20 AM, Gary Gregory <garydgreg...@gmail.com> > wrote: > >> Note that while 703 is marked as resolved, the user is still having the >> problem, so I will re-open it, and I would say another RC is needed to >> remove 703 from the generated JIRA report/release notes. >> >> In the meantime, I will attempt another round-trip of fix/test with the >> user. >> >> Gary >> >> >> On Mon, Jul 14, 2014 at 11:34 PM, Gary Gregory <garydgreg...@gmail.com> >> wrote: >> >>> Since 703 is resolved, I created >>> https://issues.apache.org/jira/browse/LOG4J2-713 and committed a fix to >>> trunk. >>> >>> I wonder what else will pop up on Android. It looks like one of our JDBC >>> classes also depends on JNDI so that would bomb too. >>> >>> Perhaps we should delay voting on 2.0 until we know how 703 and 713 play >>> out. Especially since splitting classes in two might be the only solution. >>> >>> Gary >>> >>> >>> >>> >>> On Mon, Jul 14, 2014 at 11:20 PM, Gary Gregory <garydgreg...@gmail.com> >>> wrote: >>> >>>> I have a simple fix for >>>> https://issues.apache.org/jira/browse/LOG4J2-703 "Could not find class >>>> 'javax.naming.InitialContext', referenced from method >>>> org.apache.logging.log4j.core.lookup.JndiLookup.lookup". >>>> >>>> This breaks BC in org.apache.logging.log4j.core.util.Closer. >>>> >>>> So the question is: Are we, and if yes, what modules, allowing >>>> ourselves to break BC in a non-major release. >>>> >>>> Gary >>>> >>>> >>>> On Sat, Jul 12, 2014 at 8:25 PM, Ralph Goers < >>>> ralph.go...@dslextreme.com> wrote: >>>> >>>>> This is a vote to release Log4j 2.0, the first GA release of Log4j 2. >>>>> >>>>> Please test and cast your votes. >>>>> [] +1, release the artifacts >>>>> [] -1, don't release because… >>>>> >>>>> The vote will remain open for 72 hours (or more if required). >>>>> >>>>> New features: >>>>> o LOG4J2-519: Added support for generating custom logger wrappers >>>>> that replace the existing log levels >>>>> and extended logger wrappers that add custom log levels to the >>>>> existing ones. >>>>> o LOG4J2-696: RegexFilter does not match multiline log messages. >>>>> >>>>> Fixed Bugs: >>>>> o LOG4J2-705: Fixed issue where Async Logger does not log thread >>>>> context stack data. >>>>> API change: added method getImmutableStackOrNull() to >>>>> ThreadContext.ContextStack interface. >>>>> o LOG4J2-631: Update docs to clarify how to use formatter logger and >>>>> standard logger together. >>>>> o LOG4J2-441: LoggerConfigs with no Level now inherit the Level from >>>>> their parent. >>>>> o LOG4J2-703: Android: Could not find class >>>>> 'javax.naming.InitialContext', referenced from method >>>>> org.apache.logging.log4j.core.lookup.JndiLookup.lookup. Thanks to Nelson >>>>> Melina. >>>>> o LOG4J2-699: PatternLayout manual page missing documentation on >>>>> header/footer. >>>>> o LOG4J2-625: Fixed Serialization error with SocketAppender and Async >>>>> Loggers. >>>>> (Fixed in RC2, but wasn't included in release notes.) >>>>> o LOG4J2-538: JMX GUI: fixed occasional >>>>> ArrayIndexOutOfBoundsException after pressing "reconfigure with XML >>>>> below". >>>>> (Fixed in RC2, but wasn't included in release notes.) >>>>> o LOG4J2-666: AsyncLoggerContextSelector should ensure that different >>>>> AsyncLoggerContext objects created by web app classloaders have unique >>>>> names. >>>>> o LOG4J2-683: Fix annotation processor warnings on JDK 1.7+. Thanks >>>>> to Jurriaan Mous. >>>>> o LOG4J2-694: Fix strange compilation error that popped up in a test >>>>> class. >>>>> o LOG4J2-692: Update documentation to specify only Maven 3 is >>>>> supported. >>>>> o LOG4J2-690: Log4j Web test dependencies should be in scope "test" >>>>> in the pom. Thanks to Philip Helger. >>>>> o LOG4J2-682: Special characters (tab and so on) in PatternLayout do >>>>> not work. Thanks to Scott Harrington. >>>>> o LOG4J2-686: Core's OptionConverter support for \b is broken >>>>> (affects PatternLayout). >>>>> o LOG4J2-687: Rename >>>>> org.apache.logging.log4j.core.util.Closer.closeSilent() to >>>>> closeSilently(). >>>>> o LOG4J2-688: Make org.apache.logging.log4j.core.layout.PatternLayout >>>>> immutable. >>>>> o LOG4J2-707: Some exceptions are not logged when configuration >>>>> problems are detected. >>>>> >>>>> Changes: >>>>> o LOG4J2-685: Make >>>>> org.apache.logging.log4j.core.layout.AbstractLayout immutable. >>>>> o LOG4J2-689: Update Jackson to 2.4.1. >>>>> o LOG4J2-709: Update Apache Commons Logging to 1.2 from 1.1.3. >>>>> >>>>> Tag: >>>>> https://svn.apache.org/repos/asf/logging/log4j/log4j2/tags/log4j-2.0/ >>>>> >>>>> SVN revision: 1610084 >>>>> >>>>> Web Site: http://people.apache.org/~rgoers/log4j2/ >>>>> >>>>> Artifacts: >>>>> https://repository.apache.org/content/repositories/orgapachelogging-1004/ >>>>> >>>>> You may download all the artifacts by doing: >>>>> >>>>> wget -e robots=off --cut-dirs=3 -r -p -np --no-check-certificate >>>>> https://repository.apache.org/content/repositories/orgapachelogging-1004/org/apache/logging/log4j/ >>>>> >>>>> Nexus did not send an email. The list of artifacts can be found at the >>>>> link above. >>>>> >>>> >>>> >>>> >>>> -- >>>> E-Mail: garydgreg...@gmail.com | ggreg...@apache.org >>>> Java Persistence with Hibernate, Second Edition >>>> <http://www.manning.com/bauer3/> >>>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> >>>> Spring Batch in Action <http://www.manning.com/templier/> >>>> Blog: http://garygregory.wordpress.com >>>> Home: http://garygregory.com/ >>>> Tweet! http://twitter.com/GaryGregory >>>> >>> >>> >>> >>> -- >>> E-Mail: garydgreg...@gmail.com | ggreg...@apache.org >>> Java Persistence with Hibernate, Second Edition >>> <http://www.manning.com/bauer3/> >>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> >>> Spring Batch in Action <http://www.manning.com/templier/> >>> Blog: http://garygregory.wordpress.com >>> Home: http://garygregory.com/ >>> Tweet! http://twitter.com/GaryGregory >>> >> >> >> >> -- >> E-Mail: garydgreg...@gmail.com | ggreg...@apache.org >> Java Persistence with Hibernate, Second Edition >> <http://www.manning.com/bauer3/> >> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> >> Spring Batch in Action <http://www.manning.com/templier/> >> Blog: http://garygregory.wordpress.com >> Home: http://garygregory.com/ >> Tweet! http://twitter.com/GaryGregory >> > > > > -- > E-Mail: garydgreg...@gmail.com | ggreg...@apache.org > Java Persistence with Hibernate, Second Edition > <http://www.manning.com/bauer3/> > JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> > Spring Batch in Action <http://www.manning.com/templier/> > Blog: http://garygregory.wordpress.com > Home: http://garygregory.com/ > Tweet! http://twitter.com/GaryGregory > > -- E-Mail: garydgreg...@gmail.com | ggreg...@apache.org Java Persistence with Hibernate, Second Edition <http://www.manning.com/bauer3/> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> Spring Batch in Action <http://www.manning.com/templier/> Blog: http://garygregory.wordpress.com Home: http://garygregory.com/ Tweet! http://twitter.com/GaryGregory
