[ 
https://issues.apache.org/jira/browse/LOG4J2-813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14122118#comment-14122118
 ] 

Ralph Goers commented on LOG4J2-813:
------------------------------------

I'm surprised that there aren't any unit tests for this.

> MarkerManager Log4jMarker.hasParents() returns opposite of correct result
> -------------------------------------------------------------------------
>
>                 Key: LOG4J2-813
>                 URL: https://issues.apache.org/jira/browse/LOG4J2-813
>             Project: Log4j 2
>          Issue Type: Bug
>          Components: API
>    Affects Versions: 2.0.2
>            Reporter: David Erichsen
>            Priority: Minor
>              Labels: newbie
>
> Log4JMarker.hasParents() will return false when the marker has parents, and 
> true when it has none. 
> The javadoc in the Marker interface indicates it should function the other 
> way around: 
> {quote}
> "Indicates whether this Marker has references to any other Markers.  Return 
> true if the Marker has parent Markers"
> {quote}
> The code for the implementation (that I could find) demonstrates that it 
> would function in the opposite way as it is described in that javadoc: 
> {code}
> @Override 
> public boolean hasParents() { 
>      return this.parents == null; 
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to