[
https://issues.apache.org/jira/browse/LOG4J2-813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14141315#comment-14141315
]
ASF GitHub Bot commented on LOG4J2-813:
---------------------------------------
GitHub user bwb opened a pull request:
https://github.com/apache/logging-log4j2/pull/6
LOG4J2-813
Fix org.apache.logging.log4j.MarkerManager.Log4jMarker#hasParents().
The method previously returned false when it should have returned
true, and true when it should have returned false.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bwb/logging-log4j2 marker-has-parents-error
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/logging-log4j2/pull/6.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #6
----
commit b3bd5499cc87fea6f66150324c39a3ffc5024662
Author: Brandon Barry <[email protected]>
Date: 2014-09-19T20:59:22Z
LOG4J2-813
Fix org.apache.logging.log4j.MarkerManager.Log4jMarker#hasParents().
The method previously returned false when it should have returned
true, and true when it should have returned false.
----
> MarkerManager Log4jMarker.hasParents() returns opposite of correct result
> -------------------------------------------------------------------------
>
> Key: LOG4J2-813
> URL: https://issues.apache.org/jira/browse/LOG4J2-813
> Project: Log4j 2
> Issue Type: Bug
> Components: API
> Affects Versions: 2.0.2
> Reporter: David Erichsen
> Priority: Minor
> Labels: newbie
>
> Log4JMarker.hasParents() will return false when the marker has parents, and
> true when it has none.
> The javadoc in the Marker interface indicates it should function the other
> way around:
> {quote}
> "Indicates whether this Marker has references to any other Markers. Return
> true if the Marker has parent Markers"
> {quote}
> The code for the implementation (that I could find) demonstrates that it
> would function in the opposite way as it is described in that javadoc:
> {code}
> @Override
> public boolean hasParents() {
> return this.parents == null;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
