I forget: is it okay to use a switch if the var may be null? Sent from my iPhone
> On 2015/07/07, at 2:18, Gary Gregory <[email protected]> wrote: > > Tangent: In the DatePatternConverter ctor, you could also use a String switch > instead of if/else's. > > Gary > >> On Mon, Jul 6, 2015 at 10:16 AM, Gary Gregory <[email protected]> wrote: >> Ah, OK, I was going to ask about that because I see this: >> >> if (timestamp != currentTime.timestamp) { >> >> } >> >> So I'll wait... and get back to work$ ;-) >> >> Gary >> >>> On Mon, Jul 6, 2015 at 10:15 AM, Ralph Goers <[email protected]> >>> wrote: >>> OK - but I haven’t updated the patch to resolve the error Remko found. I >>> will do that when I get a chance today. >>> >>> Ralph >>> >>>> On Jul 6, 2015, at 10:05 AM, Gary Gregory <[email protected]> wrote: >>>> >>>> I'll review the patch ASAP... >>>> >>>> Gary >>>> >>>>> On Mon, Jul 6, 2015 at 8:45 AM, Ralph Goers <[email protected]> >>>>> wrote: >>>>> I had planned on committing the fix for 812 as soon as I got agreement >>>>> from everyone that it is the right approach. The code is all done and all >>>>> the unit tests pass. >>>>> >>>>> Ralph >>>>> >>>>>> On Jul 6, 2015, at 8:14 AM, Gary Gregory <[email protected]> wrote: >>>>>> >>>>>> Hi All, >>>>>> >>>>>> Thinking aloud: >>>>>> >>>>>> It feels like the changes we are discussing in LOG4J-812 and LOG4J-1074 >>>>>> are important and tricky to get right. >>>>>> >>>>>> I wonder if the project would benefit from releasing the large set of >>>>>> fixes, features, and updates we have now as 2.4 and then getting back to >>>>>> working on LOG4J-812 and LOG4J-1074 for 2.5. >>>>>> >>>>>> Thoughts? >>>>>> >>>>>> Gary >>>>>> >>>>>>> On Sat, Jun 27, 2015 at 6:05 PM, Ralph Goers >>>>>>> <[email protected]> wrote: >>>>>>> I’ve assigned Jiras I would like to work on to myself. There are >>>>>>> probably more I’d like to do. That said, I probably won’t get to them >>>>>>> before 2.4 is released. >>>>>>> >>>>>>> Ralph >>>>>>> >>>>>>>> On Jun 27, 2015, at 3:44 PM, Gary Gregory <[email protected]> >>>>>>>> wrote: >>>>>>>> >>>>>>>> Devs, >>>>>>>> >>>>>>>> Curious: Do you all have set list of JIRAs you are addressing before >>>>>>>> 2.4? >>>>>>>> >>>>>>>> Gary >>>>>>>> >>>>>>>>> On Tue, Jun 2, 2015 at 5:11 PM, Gary Gregory <[email protected]> >>>>>>>>> wrote: >>>>>>>>> End of June sounds good. >>>>>>>>> >>>>>>>>> Gary >>>>>>>>> >>>>>>>>> >>>>>>>>> -------- Original message -------- >>>>>>>>> From: Ralph Goers <[email protected]> >>>>>>>>> Date: 06/02/2015 15:09 (GMT-08:00) >>>>>>>>> To: Log4J Developers List <[email protected]> >>>>>>>>> Subject: Re: Releasing 2.4 >>>>>>>>> >>>>>>>>> I would prefer to find some time to work on some issues instead of >>>>>>>>> spending that on doing a release. But no later than the end of June. >>>>>>>>> >>>>>>>>> Ralph >>>>>>>>> >>>>>>>>>> On Jun 2, 2015, at 3:02 PM, Gary Gregory <[email protected]> >>>>>>>>>> wrote: >>>>>>>>>> >>>>>>>>>> It's been almost a month since 2.3 and we already have a nice little >>>>>>>>>> batch of changes for 2.4. >>>>>>>>>> >>>>>>>>>> In particular, the 1.2 compatibility fixes to NDC pop() and peek() >>>>>>>>>> would be good to push out ASAP. >>>>>>>>>> >>>>>>>>>> Thoughts? >>>>>>>>>> >>>>>>>>>> Gary >>>>>>>>>> >>>>>>>>>> -- >>>>>>>>>> E-Mail: [email protected] | [email protected] >>>>>>>>>> Java Persistence with Hibernate, Second Edition >>>>>>>>>> JUnit in Action, Second Edition >>>>>>>>>> Spring Batch in Action >>>>>>>>>> Blog: http://garygregory.wordpress.com >>>>>>>>>> Home: http://garygregory.com/ >>>>>>>>>> Tweet! http://twitter.com/GaryGregory >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> -- >>>>>>>> E-Mail: [email protected] | [email protected] >>>>>>>> Java Persistence with Hibernate, Second Edition >>>>>>>> JUnit in Action, Second Edition >>>>>>>> Spring Batch in Action >>>>>>>> Blog: http://garygregory.wordpress.com >>>>>>>> Home: http://garygregory.com/ >>>>>>>> Tweet! http://twitter.com/GaryGregory >>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> E-Mail: [email protected] | [email protected] >>>>>> Java Persistence with Hibernate, Second Edition >>>>>> JUnit in Action, Second Edition >>>>>> Spring Batch in Action >>>>>> Blog: http://garygregory.wordpress.com >>>>>> Home: http://garygregory.com/ >>>>>> Tweet! http://twitter.com/GaryGregory >>>> >>>> >>>> >>>> -- >>>> E-Mail: [email protected] | [email protected] >>>> Java Persistence with Hibernate, Second Edition >>>> JUnit in Action, Second Edition >>>> Spring Batch in Action >>>> Blog: http://garygregory.wordpress.com >>>> Home: http://garygregory.com/ >>>> Tweet! http://twitter.com/GaryGregory >> >> >> >> -- >> E-Mail: [email protected] | [email protected] >> Java Persistence with Hibernate, Second Edition >> JUnit in Action, Second Edition >> Spring Batch in Action >> Blog: http://garygregory.wordpress.com >> Home: http://garygregory.com/ >> Tweet! http://twitter.com/GaryGregory > > > > -- > E-Mail: [email protected] | [email protected] > Java Persistence with Hibernate, Second Edition > JUnit in Action, Second Edition > Spring Batch in Action > Blog: http://garygregory.wordpress.com > Home: http://garygregory.com/ > Tweet! http://twitter.com/GaryGregory
