[
https://issues.apache.org/jira/browse/LOG4J2-1365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15242898#comment-15242898
]
Mikael Ståldal commented on LOG4J2-1365:
----------------------------------------
There is one problem with this approach, what if the the StringBuilder /
CharSequence in the Message is null? It seems like that can be the case in
SimpleMessage, ReusableSimpleMessage and RingBufferLogEvent.
However, in RingBufferLogEvent that would break the current
{{getFormattedMessage()}} method as well:
{code}
public String getFormattedMessage() {
return messageText.toString();
}
{code}
> Add CharSequenceFormattable interface for Messages to improve performance of
> Layouts
> ------------------------------------------------------------------------------------
>
> Key: LOG4J2-1365
> URL: https://issues.apache.org/jira/browse/LOG4J2-1365
> Project: Log4j 2
> Issue Type: Improvement
> Components: Layouts
> Affects Versions: 2.5
> Reporter: Mikael Ståldal
> Assignee: Mikael Ståldal
> Priority: Minor
>
> {code}
> public interface CharSequenceFormattable {
> CharSequence getFormattedCharSequence();
> }
> {code}
> This can be implemented by Messages where it makes sense and used by Layouts
> where it makes sense.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
