[
https://issues.apache.org/jira/browse/LOG4J2-1620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15748694#comment-15748694
]
ASF GitHub Bot commented on LOG4J2-1620:
----------------------------------------
Github user garydgregory commented on the issue:
https://github.com/apache/logging-log4j2/pull/50
I am in the process of updating this appender to the builder pattern. You
might want to wait until I am done.
Gary
On Dec 14, 2016 7:26 AM, "thedutchy" <notificati...@github.com> wrote:
> After going through the documentation again, I decided the proper place
> for the parameter is not in the properties. Instead it should go in the
> appender parameters. I will close this pull request and create a new one,
> this way I can also correct the PR to 1733.
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/logging-log4j2/pull/50#issuecomment-267062816>,
> or mute the thread
>
<https://github.com/notifications/unsubscribe-auth/ABIfN78DuS3aamTbF8qD4mQ52DyFdqbzks5rIAqigaJpZM4LMKJB>
> .
>
> 2.7-rc1: RollingFileAppender immediateFlush default value should be true, not
> false
> -----------------------------------------------------------------------------------
>
> Key: LOG4J2-1620
> URL: https://issues.apache.org/jira/browse/LOG4J2-1620
> Project: Log4j 2
> Issue Type: Bug
> Components: Appenders
> Affects Versions: 2.7
> Reporter: Sascha Scholz
> Assignee: Gary Gregory
>
> The default value of the immediaFlush property in RollingFile appender was
> changed from true to false (compared with 2.6.2). The change was introduced
> with
> {noformat}
> a82794f06e3bc095ef0bca41b98c5d1ea915de76 is the first bad commit
> commit a82794f06e3bc095ef0bca41b98c5d1ea915de76
> Author: Gary Gregory <ggreg...@apache.org>
> Date: Fri Aug 19 17:27:26 2016 -0700
> [LOG4J2-1504] RollingFileAppender should be able to create files
> on-demand.
> :040000 040000 3d3faa81429c2ff83db3b1672a2700e2efe770e3
> 279da0b08553454f69fdbebfcdb855b21dc7c2ae M log4j-core
> :040000 040000 9548cb83e88b752d42e80ef6cab3463eed9b868c
> 5a23c7038b1f4bb49c8b6b8727d4a681db3c2ae8 M src
> {noformat}
> It looks to me from the commit message that this change was not intended. And
> it breaks my current usage. I'd have to explicitly set the value to true now
> in order to avoid a regression in my code.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
For additional commands, e-mail: log4j-dev-h...@logging.apache.org
