[
https://issues.apache.org/jira/browse/LOG4J2-1620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15749033#comment-15749033
]
ASF GitHub Bot commented on LOG4J2-1620:
----------------------------------------
Github user garydgregory commented on the issue:
https://github.com/apache/logging-log4j2/pull/50
This patch does not feel right to me because the configuration properties
array is used to carry this new setting. These properties are meant to be used
only for Kafka properties
https://kafka.apache.org/documentation.html#producerconfigs
IMO, what needs to happen is convert the appender to using a builder and
then add a new setting.
The build changes are now in Git master. See Apache JIRA LOG4J2-1739.
> 2.7-rc1: RollingFileAppender immediateFlush default value should be true, not
> false
> -----------------------------------------------------------------------------------
>
> Key: LOG4J2-1620
> URL: https://issues.apache.org/jira/browse/LOG4J2-1620
> Project: Log4j 2
> Issue Type: Bug
> Components: Appenders
> Affects Versions: 2.7
> Reporter: Sascha Scholz
> Assignee: Gary Gregory
>
> The default value of the immediaFlush property in RollingFile appender was
> changed from true to false (compared with 2.6.2). The change was introduced
> with
> {noformat}
> a82794f06e3bc095ef0bca41b98c5d1ea915de76 is the first bad commit
> commit a82794f06e3bc095ef0bca41b98c5d1ea915de76
> Author: Gary Gregory <ggreg...@apache.org>
> Date: Fri Aug 19 17:27:26 2016 -0700
> [LOG4J2-1504] RollingFileAppender should be able to create files
> on-demand.
> :040000 040000 3d3faa81429c2ff83db3b1672a2700e2efe770e3
> 279da0b08553454f69fdbebfcdb855b21dc7c2ae M log4j-core
> :040000 040000 9548cb83e88b752d42e80ef6cab3463eed9b868c
> 5a23c7038b1f4bb49c8b6b8727d4a681db3c2ae8 M src
> {noformat}
> It looks to me from the commit message that this change was not intended. And
> it breaks my current usage. I'd have to explicitly set the value to true now
> in order to avoid a regression in my code.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
For additional commands, e-mail: log4j-dev-h...@logging.apache.org
