[
https://issues.apache.org/jira/browse/LOG4J2-1761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15791734#comment-15791734
]
Gary Gregory commented on LOG4J2-1761:
--------------------------------------
That's a lot of new code in a tricky area to consider without a single unit
test. I can't see considering any of it without significant test coverage. Are
you able to add unit test and your new code in a patch in unified diff format?
> Support for standard java queues for the async logger
> -----------------------------------------------------
>
> Key: LOG4J2-1761
> URL: https://issues.apache.org/jira/browse/LOG4J2-1761
> Project: Log4j 2
> Issue Type: Improvement
> Components: Core
> Affects Versions: 2.7
> Reporter: Kim Northrop
> Priority: Minor
> Attachments: AsyncLogEvent.java, AsyncLoggerWithQueue.java,
> AsyncLoggerWithQueueContext.java, AsyncLoggerWithQueueContextSelector.java,
> QueueWrapper.java, QueueWrapperCLQ.java, QueueWrapperLBQ.java,
> QueueWrapperLTQ.java
>
>
> Please add support for standard java queues (LinkedTransferQueue,
> ArrayBlockingQueue, LinkedBlockingQueue, ConcurrentLinkedQueue) to the async
> logger. I will attach some classes for usage with System properties
> (Log4jContextSelector=org.apache.logging.log4j.core.async.AsyncLoggerWithQueueContextSelector,
> LoggerQueue.Capacity=<capacity>, LoggerQueue.Type=<currently one of
> LinkedTransferQueue, ConcurrentLinkedQueue, LinkedBlockingQueue>). Since most
> of these queues allocate new nodes for new elements I have not implemented
> usage of thread locals for the log events.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
For additional commands, e-mail: log4j-dev-h...@logging.apache.org
