How do I add myself as a reviewer? Ralph
> On Jan 17, 2017, at 2:05 PM, Mikael Ståldal <mikael.stal...@magine.com> wrote: > > OK, Pull Request here: > > https://github.com/apache/logging-log4j2/pull/55 > <https://github.com/apache/logging-log4j2/pull/55> > > On Jan 17, 2017 6:58 PM, "Matt Sicker" <boa...@gmail.com > <mailto:boa...@gmail.com>> wrote: > Are you able to make a PR on GitHub for review? That'd be a neat way to > interactively review our own internal branches. Not sure if you need to do it > from a fork, though. > > On 17 January 2017 at 10:20, Mikael Ståldal <mikael.stal...@magine.com > <mailto:mikael.stal...@magine.com>> wrote: > I think we should get LOG4J2-1748 and LOG4J2-1780 resolved before 2.8, I have > a branch out for review. > > > On Tue, Jan 17, 2017 at 5:04 PM, Matt Sicker <boa...@gmail.com > <mailto:boa...@gmail.com>> wrote: > I'm working on getting the Log4j Scala repo set up independently from the > main Log4j repo (and doing Log4j Boot on the side; this will be released > independently, so don't worry about this blocking anything) and doing some > general site cleanups and whatnot. For 2.8, the other non-core modules will > most likely remain where they are and the Log4j Scala API repo gets to be our > first foray into the separated repos space. > > Feature-wise, are there any other things we'd like to complete before cutting > a 2.8 release? Based on the ongoing Zookeeper migration, I see the pain > points of migrating config formats being brought up again, so it would be > great to get our Log4j 1 config support in this release, but that depends on > timing, too (we could always RERO and add it to the next release if nobody > has time to finish that feature). > > -- > Matt Sicker <boa...@gmail.com <mailto:boa...@gmail.com>> > > > > -- > > > Mikael Ståldal > Senior software developer > > Magine TV > mikael.stal...@magine.com <mailto:mikael.stal...@magine.com> > Grev Turegatan 3 | 114 46 Stockholm, Sweden | www.magine.com > <http://www.magine.com/> > > Privileged and/or Confidential Information may be contained in this message. > If you are not the addressee indicated in this message > (or responsible for delivery of the message to such a person), you may not > copy or deliver this message to anyone. In such case, > you should destroy this message and kindly notify the sender by reply email. > > > > > -- > Matt Sicker <boa...@gmail.com <mailto:boa...@gmail.com>>