Ralph, you can add yourself as a reviewer on GitHub by commenting on a line
in the diff. It should offer you the ability to start a review then.
On 18 January 2017 at 08:17, Apache <ralph.go...@dslextreme.com> wrote:
> That will probably cover 80% of the use cases. Another option is to use a
> proxy factory that reads the file and determines if logger.rootLogger or
> logger.appender is present and routes to the Log4j1ConfigurationFactory if
> it is and the Log4j2 factory if it is not.
>
> Ralph
>
> On Jan 18, 2017, at 6:24 AM, Remko Popma <remko.po...@gmail.com> wrote:
>
> FYI, it seems to me that if Log4j1ConfigurationFactory has SUFFIXES = {
> "log4j.properties"}, then it would not clash with log4j2.properties file
> but could still work as one of the automatic configuration factories.
>
> On Wed, Jan 18, 2017 at 9:51 PM, Mikael Ståldal <mikael.stal...@magine.com
> > wrote:
>
>> I think that Log4j1ConfigurationConverter does not handle Log4j 1.x
>> property substitution correctly. Log4j 1.x let you override properties with
>> Java System Properties, but Log4j 2.x only do that when you specify
>> ${sys:key}. Right?
>>
>> So the converter needs to convert from ${key} to ${sys:key}, and also
>> have some logic to handle the case of default value when present.
>>
>> On Tue, Jan 17, 2017 at 8:11 PM, Gary Gregory <garydgreg...@gmail.com>
>> wrote:
>>
>>> On Tue, Jan 17, 2017 at 8:04 AM, Matt Sicker <boa...@gmail.com> wrote:
>>>
>>>> I'm working on getting the Log4j Scala repo set up independently from
>>>> the main Log4j repo (and doing Log4j Boot on the side; this will be
>>>> released independently, so don't worry about this blocking anything) and
>>>> doing some general site cleanups and whatnot. For 2.8, the other non-core
>>>> modules will most likely remain where they are and the Log4j Scala API repo
>>>> gets to be our first foray into the separated repos space.
>>>>
>>>> Feature-wise, are there any other things we'd like to complete before
>>>> cutting a 2.8 release? Based on the ongoing Zookeeper migration, I see the
>>>> pain points of migrating config formats being brought up again, so it would
>>>> be great to get our Log4j 1 config support in this release,
>>>>
>>>
>>> There is already some support for the Log4j1 properties format. Nothing
>>> for XML IIRC though.
>>>
>>> Gary
>>>
>>> but that depends on timing, too (we could always RERO and add it to the
>>>> next release if nobody has time to finish that feature).
>>>>
>>>> --
>>>> Matt Sicker <boa...@gmail.com>
>>>>
>>>
>>>
>>>
>>> --
>>> E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
>>> Java Persistence with Hibernate, Second Edition
>>> <https://www.amazon.com/gp/product/1617290459/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1617290459&linkCode=as2&tag=garygregory-20&linkId=cadb800f39946ec62ea2b1af9fe6a2b8>
>>>
>>> <http://ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1617290459>
>>> JUnit in Action, Second Edition
>>> <https://www.amazon.com/gp/product/1935182021/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182021&linkCode=as2&tag=garygregory-20&linkId=31ecd1f6b6d1eaf8886ac902a24de418%22>
>>>
>>> <http://ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1935182021>
>>> Spring Batch in Action
>>> <https://www.amazon.com/gp/product/1935182951/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182951&linkCode=%7B%7BlinkCode%7D%7D&tag=garygregory-20&linkId=%7B%7Blink_id%7D%7D%22%3ESpring+Batch+in+Action>
>>> <http://ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1935182951>
>>> Blog: http://garygregory.wordpress.com
>>> Home: http://garygregory.com/
>>> Tweet! http://twitter.com/GaryGregory
>>>
>>
>>
>>
>> --
>> [image: MagineTV]
>>
>> *Mikael Ståldal*
>> Senior software developer
>>
>> *Magine TV*
>> mikael.stal...@magine.com
>> Grev Turegatan 3 | 114 46 Stockholm, Sweden | www.magine.com
>>
>> Privileged and/or Confidential Information may be contained in this
>> message. If you are not the addressee indicated in this message
>> (or responsible for delivery of the message to such a person), you may
>> not copy or deliver this message to anyone. In such case,
>> you should destroy this message and kindly notify the sender by reply
>> email.
>>
>
>
>
--
Matt Sicker <boa...@gmail.com>
