Since the change isn’t required and it is breaking log4j-perf can you please revert it?
Ralph > On Jan 30, 2017, at 11:15 AM, Apache <ralph.go...@dslextreme.com> wrote: > > OK. But according to Matt this change wasn’t required. What was breaking that > needed fixing? > > Ralph > >> On Jan 30, 2017, at 9:49 AM, Gary Gregory <garydgreg...@gmail.com >> <mailto:garydgreg...@gmail.com>> wrote: >> >> >> >> On Jan 30, 2017 12:28 AM, "Apache" <ralph.go...@dslextreme.com >> <mailto:ralph.go...@dslextreme.com>> wrote: >> Gary moved it, presumably since many modules need to generate a .dat file. >> >> Right, that was the idea. >> >> Gary >> >> Ralph >> >>> On Jan 29, 2017, at 9:55 AM, Matt Sicker <boa...@gmail.com >>> <mailto:boa...@gmail.com>> wrote: >>> >>> That maven-compiler-plugin config was originally only included in >>> log4j-core in order to allow the PluginProcessor annotation processor to >>> re-run against log4j-core without needing to split it into its own jar. I'm >>> not sure why it's configured for everything now. >>> >>> On 29 January 2017 at 08:59, Ralph Goers <ralph.go...@dslextreme.com >>> <mailto:ralph.go...@dslextreme.com>> wrote: >>> Yes. >>> >>> Ralph >>> >>> On Jan 28, 2017, at 11:59 PM, Remko Popma <remko.po...@gmail.com >>> <mailto:remko.po...@gmail.com>> wrote: >>> >>>> Ralph, are your benchmark results with 4 threads (-t 4)? >>>> >>>> On Sun, Jan 29, 2017 at 5:51 PM, Apache <ralph.go...@dslextreme.com >>>> <mailto:ralph.go...@dslextreme.com>> wrote: >>>> While I couldn’t get it to work with Log4j 2.8 the results I get for 2.7 >>>> do not match Ceki’s at all. These are the results for Java 7: >>>> >>>> Benchmark Mode >>>> Samples Score Error Units >>>> o.a.l.l.p.j.FileAppenderBenchmark.julFile thrpt 10 >>>> 105746.361 ± 2995.187 ops/s >>>> o.a.l.l.p.j.FileAppenderBenchmark.log4j1File thrpt 10 >>>> 811996.955 ± 18110.525 ops/s >>>> o.a.l.l.p.j.FileAppenderBenchmark.log4j2File thrpt 10 >>>> 1986884.744 ± 42949.953 ops/s >>>> o.a.l.l.p.j.FileAppenderBenchmark.log4j2RAF thrpt 10 >>>> 4020251.137 ± 176621.025 ops/s >>>> o.a.l.l.p.j.FileAppenderBenchmark.logbackFile thrpt 10 >>>> 228331.672 ± 2420.898 ops/s >>>> >>>> Here are the numbers for Java 8: >>>> >>>> Benchmark Mode >>>> Samples Score Error Units >>>> o.a.l.l.p.j.FileAppenderBenchmark.julFile thrpt 10 >>>> 105836.910 ± 9430.973 ops/s >>>> o.a.l.l.p.j.FileAppenderBenchmark.log4j1File thrpt 10 >>>> 816316.422 ± 12492.398 ops/s >>>> o.a.l.l.p.j.FileAppenderBenchmark.log4j2File thrpt 10 >>>> 2042991.944 ± 15957.247 ops/s >>>> o.a.l.l.p.j.FileAppenderBenchmark.log4j2RAF thrpt 10 >>>> 4006968.171 ± 285275.918 ops/s >>>> o.a.l.l.p.j.FileAppenderBenchmark.logbackFile thrpt 10 >>>> 231574.725 ± 2266.484 ops/s >>>> >>>> >>>> To correlate to microseconds as Ceki is doing, I get 105 for jul, 816 for >>>> log4j 1, 2042 for Log4j 2, 4007 for Log4j 2 RAF, and 232 for Logback. I >>>> think he must have somehow lost a digit for log4j as that would correlate >>>> with the numbers he reported. >>>> >>>> My machine has 4 cores (8 hyper threads) and is using an SSD. >>>> >>>> Ralph >>>> >>>>> On Jan 29, 2017, at 12:39 AM, Apache <ralph.go...@dslextreme.com >>>>> <mailto:ralph.go...@dslextreme.com>> wrote: >>>>> >>>>> I can no longer get the benchmarks to work. I get >>>>> >>>>> java.lang.IllegalArgumentException: Benchmark does not match a class >>>>> at org.openjdk.jmh.util.ClassUtils.loadClass(ClassUtils.java:90) >>>>> at org.openjdk.jmh.runner.BaseRunner.runBenchmark(BaseRunner.java:198) >>>>> at org.openjdk.jmh.runner.BaseRunner.runBenchmarks(BaseRunner.java:95) >>>>> at org.openjdk.jmh.runner.ForkedRunner.run(ForkedRunner.java:51) >>>>> at org.openjdk.jmh.runner.ForkedMain.main(ForkedMain.java:68) >>>>> Caused by: java.lang.ClassNotFoundException: >>>>> org.apache.logging.log4j.perf.jmh.generated.FileAppenderBenchmark_julFile >>>>> at java.net.URLClassLoader$1.run(URLClassLoader.java:366) >>>>> at java.net.URLClassLoader$1.run(URLClassLoader.java:355) >>>>> at java.security.AccessController.doPrivileged(Native Method) >>>>> at java.net.URLClassLoader.findClass(URLClassLoader.java:354) >>>>> at java.lang.ClassLoader.loadClass(ClassLoader.java:425) >>>>> at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:308) >>>>> at java.lang.ClassLoader.loadClass(ClassLoader.java:358) >>>>> at java.lang.Class.forName0(Native Method) >>>>> at java.lang.Class.forName(Class.java:195) >>>>> at org.openjdk.jmh.util.ClassUtils.loadClass(ClassUtils.java:72) >>>>> ... 4 more >>>>> >>>>>> On Jan 28, 2017, at 6:13 PM, Remko Popma <remko.po...@gmail.com >>>>>> <mailto:remko.po...@gmail.com>> wrote: >>>>>> >>>>>> >>>>>> On Jan 29, 2017, at 9:38, Remko Popma <remko.po...@gmail.com >>>>>> <mailto:remko.po...@gmail.com>> wrote: >>>>>> >>>>>>> I want to ask a favor: can anyone run the FileAppenderBenchmark >>>>>>> benchmark >>>>>>> (with -f 1 -wi 10 -i 10 -t 4) and post the summary? Someone is >>>>>>> reporting a performance regression. >>>>>> This is the regression report: >>>>>> https://mobile.twitter.com/ceki/status/825368324146155520 >>>>>> <https://mobile.twitter.com/ceki/status/825368324146155520> >>>>>> >>>>>> https://mobile.twitter.com/ceki/status/825370795157368832 >>>>>> <https://mobile.twitter.com/ceki/status/825370795157368832> >>>>>>> I get a strange error when trying to run JMH benchmarks and wonder if >>>>>>> it is just me. >>>>>>> >>>>>>> Remko >>>>>>> >>>>>>> Sent from my iPhone >>>>> >>>> >>>> >>> >>> >>> >>> -- >>> Matt Sicker <boa...@gmail.com <mailto:boa...@gmail.com>> >> >> >
