On Thu, 2004-01-08 at 10:22, Olli Blackburn wrote:
> As you asked ;-)
> 
> 1) When changing the props of a receiver you have to change focus to
> another prop to action the change. This is particularly odd when
> changing the threshold. On text fields (such as socket port) pressing
> enter should action the change.
> 

Yes, already spotted that. It is a bit annoying.

> 2) I can't get find next to work. Try searching for 209 in the tutorial
> generator 1. It doesn't move beyond the first message with 209 in the
> Message field.
> 

Find has been broken for a while, as we changed over to a new Expression
rule structure.  For now you can use the 'Refine Focus' box to do
something like:

Message like '.*Keyword.*'

Eventually we'll tweak the simple find to just translate it to an
expression that covers all the text fields.

> 3) Find should scroll the events panel to the event found.
> 

If Find worked, it would do that.  I would ideally like to have a
Scrollbar decorator like Eclipse has to mark where the matches are, but
that might be difficult.

> 4) The docs for what you can do in the Refine Focus On field need
> writing - I suspect this is a very powerful aspect of chainsaw if only I
> knew the secret.
> 

That is not the only docs that need written....  8-|

While the current Expression editor does support the CTRL+Space style
mechanism you would expect from a java IDE editor, we'd like to improve
that.  

> 5) the Pause button on the toolbar should change to a Play icon when you
> pause. Likewise, the play and pause icons in the receivers panel should
> be a single icon that changes from play to pause depending on context.
> 

Contentious.  A toggle button should maintain it's icon, as the
'pressed' or unpressed visual states indicates the state of the
underlying model.  You would expect 2 buttons, a play & pause that
toggle each other on click, but IMHO a single toggle button with the
same icon should be sufficient.

> 6) I created a new XMLSocketReceiver. I entered foo for the name and
> 44440 for the port. I left the input focus in the port field and clicked
> ok. The receiver was created with a port of 0.
> 

Yeah, definately work in that whole focus management so those values
don't get lost.

> 7) It took me a long time to work out the what the panel below the
> logger tree represented - it's the exclude list. I'd suggest putting a
> title on it. Also, it takes a double click to remove an entry from it.
> I'd suggest a single click to clear the check box (and stop it being
> used for exclusion filtering), and a right click->remove menu to remove
> it from the list completely.
> 

That was a quick addition by me.  There's not even a Tooltip to help you
understand what it is for.  When I can think of a good way to label
that, I will.  Not only is it confusing for new people, it looks crap
right now.

> 8) Double clicking on a column heading right hand boundary should widen
> that column to the width of the widest value in the column.
> 

I would like that too, but it is a bit more difficult than I thought. 
We'll hopefully find the right way to do it.

> 9) The (I presume) power of the Tab Identifier expression needs to be
> documented.
> 

Goes without saying.

> 10) In the Log Panel Preferences - Column dialog you have to double
> click to check/uncheck the column selections - it should be a single
> click action.
> 

Good point.

> 11) Clicking the Show/Hide Details Pane toolbar button hides the details
> pane. Clicking it again restores the pane, kinda. It returns minimized
> at the bottom and you need to resize it in order to see any details.
> 

You won't believe how much time I have spent trying to fix this one.  I
have no idea why.  I am at the point where I think it is actually a
problem with the JSplitPane.  If you have experience with this one,
HELP, it drives me nuts too.

> 12) Are they Panes or Panels - both terms are used across the tool tips
> and tutorial - you should standardize on one.
> 

Consistency is not my middle name, but I wish it was sometimes.  Thanks.

> 13) The file menu has 4 actions for ctrl+O - it can clearly only be one
> of them.
> 

Yep.

> 14) The Current Tab menu ends with "Other options...." indicating there
> are some tasks that can only be accomplished from the right-click menu.
> All tasks should be available directly from the main menus without
> needing to use right-click.
> 

Yes.

> 15) I'd like to be able to specify default event pane columns for all
> new tabs on an application wide basis. This would save me needing to
> individually customize every tab.
> 

Nice feature.  Agreed.

> 16) Clicking on an event shows its details, but focus is almost
> instantly removed and placed on the latest event to arrive. This is very
> off-putting when you're trying to read what happened. If I explicitly
> select an event (by clicking or find) focus should remain on that event
> until I select another event. I think this just requires Find and
> click-select to turn off "scroll to bottom". I can then simply select
> "Scroll to bottom" to get back to the default mode.
> 

If you have Scroll to bottom turned on, you are indicating that you want
to follow new events.  We should discuss a clean way for a user to
indicate a fast way of turning that off, as I don't think simply
selecting a row should automatically turn ScrollToBottom off, that would
be just, if not more annoying (maybe some KEY + mouse click modifier)

> Perhaps a "selected" event should be highlighted in blue as now, but in
> scroll-to-bottom mode the last event should be outlined in a dotted blue
> box to distinguish it from the selected state (c.f. Windows Explorer).
> 

Mmm, have to think about that one.

> 17) How do I configure the cycle size?
> 

It will be made available within the app-pref area (the size new tabs
are created).  At the moment we have no plans to allow modifying the
buffer size on the fly, but we might get to that.

> 18) Clicking on a logger in the tree should focus on it. Having to
> enable the "focus on" mode is an unnecessary additional step.
> 

Disagree, what if you accidently click? We can enable a double-click
default action though, that would make sense I think.

> 19) There's no way to change the width of the receivers pane. More
> specifically, I wanted to widen the events pane and had to widen the
> entire chainsaw window instead of making the events pane wider and the
> receivers narrower.
> 

I think I am going to make the Receivers panel a true Plugin, and it
will have a tab of it's own.  Hows that?

> 20) I don't know what the information in the status bar is telling me.
> 

The message area, or the other number values?  (Would tooltips help
there?)

> 21) I have valid timestamps in the events pane (dated 2004-01-06) but
> when I select an event the date in the details pane is wrong
> (2004-50-06). The time is ok, it's just the month that's wrong. I see
> this in the tutorial generator 1 and my own logs.
> 

I will have to look at that one.

> 22) As you type in the find field the first matching event is
> automatically selected as you continue to complete the search string. If
> you backspace it doesn't unwind back to the first matching event
> following the current selection.
> 

throw new FindIsReallyBrokenException();

> 23) The substitutable values for the pattern editor should be
> documented.
> 

They are, in the  PatternLayout javadoc (we just use that for
rendering), but we should have add a help ref there, that would be
straight forward.

> 24) The tool tip time for the events should be tunable separately from
> the time for button tool tips - the events are long and take longer to
> read so I'd typically like the event tool tip to remain displayed for
> longer (perhaps indefinitely until the mouse moved would be a good
> option too).

Yes, we haven't hooked up the menu to open the pattern editor for the
tooltip layout, but that is an easy one.

> 25) I'd like to be able to reorder the tabs by dragging them into an
> order that works for me.
> 

That would be great, JTabbedPane doesn't have that native support
though, might be tricky.

> 26) There is a lot of debug chat in the console window that starts
> chainsaw, and in ChainsawCentral.

You can turn that off by putting:

log4j.debug=false

In your build.properties, I think (or maybe I hardcoded that in the
build.xml...)

> 27) I've had two NPEs:
> 
> java.lang.NullPointerException
>         at javax.swing.ImageIcon.<init>(ImageIcon.java:161)
>         at javax.swing.ImageIcon.<init>(ImageIcon.java:147)
>         at
> com.sun.java.swing.plaf.windows.WindowsFileChooserUI$ShortCutPanel.<init
> >(WindowsFileChooserUI.java:603)
>         at
> com.sun.java.swing.plaf.windows.WindowsFileChooserUI.installComponents(W
> indowsFileChooserUI.java:361)
>         at
> javax.swing.plaf.basic.BasicFileChooserUI.installUI(BasicFileChooserUI.j
> ava:130)
>         at
> com.sun.java.swing.plaf.windows.WindowsFileChooserUI.installUI(WindowsFi
> leChooserUI.java:176)


<snip/>

Bizzare, haven't seen that one.  Happen very often?

> java.lang.NullPointerException
>         at java.lang.String.startsWith(String.java:1006)
>         at java.lang.String.startsWith(String.java:1035)
>         at
> org.apache.log4j.chainsaw.LoggerNameTreePanel$18.evaluate(Unknown
> Source)
>         at
> org.apache.log4j.chainsaw.LoggerNameTreePanel.evaluate(Unknown Source)
>         at org.apache.log4j.chainsaw.RuleMediator.evaluate(Unknown
> Source)

This one looks like a bug. Thanks.

> 28) My receiver definitions aren't persisted across runs of chainsaw.
> 

I'm working on a concept of Favourites and 'profiles' at the moment, but
getting distracted by that RealPayingJob thing at the moment.  Sucks.

> 29) What's the difference between pausing a receiver and pausing
> incoming events on the toolbar. If they're the same they should be
> merged to one icon, or at least change state together.
> 

We might get rid of pause at the Receiver level, but the intent was to
be able to discard events as early as possible to make things more
efficient.  By the time the LoggingEvent gets to the LogPanel where that
Pause is evaluated. there has been  good amount of code being executed.

> 
> Sorry of I missed the point on some of these items - these are just my
> thoughts and experiences as a first time user. Hope it helps! 

Fantastic, thank you very much for taking the time and effort to
articulate all these thoughts and issues.

Now my next question, interested in helping out any?   :)  You can
always start with a patch or 2 with the things that really bug you. 
That's usually how things get done here by Scott and I, the
features/issues that we really need.  That might not always be inline
with what other people wish for though.

Thanks again.

Paul Smith


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to