[ https://issues.apache.org/jira/browse/LOG4NET-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15374796#comment-15374796 ]
ASF GitHub Bot commented on LOG4NET-467: ---------------------------------------- Github user jasonwilliams200OK commented on a diff in the pull request: https://github.com/apache/log4net/pull/16#discussion_r70601024 --- Diff: src/Util/ReadOnlyPropertiesDictionary.cs --- @@ -215,8 +216,13 @@ public virtual void GetObjectData(SerializationInfo info, StreamingContext conte string entryKey = entry.Key as string; object entryValue = entry.Value; - // If value is serializable then we add it to the list - if (entryKey != null && entryValue != null && entryValue.GetType().IsSerializable) + // If value is serializable then we add it to the list +#if NETSTANDARD1_3 + bool isSerializable = entryValue.GetType().GetTypeInfo().IsSerializable; +#else + bool isSerializable = entryValue.GetType().IsSerializable; +#endif + if (entryKey != null && entryValue != null && isSerializable) { --- End diff -- nit: indentation under `#if` `#else` and that of `if (entryKey` is off > Is .NET Core, will be supported in the near future, or not > ---------------------------------------------------------- > > Key: LOG4NET-467 > URL: https://issues.apache.org/jira/browse/LOG4NET-467 > Project: Log4net > Issue Type: New Feature > Components: Core > Affects Versions: 1.2.13 > Reporter: san kan > Labels: features > > As you know, ms is moving heavily toward .Net core: > https://github.com/dotnet/core > so, is there a road map for making a version that supports it? > and i noticed that log4net, has not been updated for 2 years. > so is it maintained, or being forgotten? -- This message was sent by Atlassian JIRA (v6.3.4#6332)