[
https://issues.apache.org/jira/browse/LOG4NET-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15419846#comment-15419846
]
ASF GitHub Bot commented on LOG4NET-467:
----------------------------------------
Github user jasonwilliams200OK commented on a diff in the pull request:
https://github.com/apache/log4net/pull/16#discussion_r74683879
--- Diff: src/Util/PatternStringConverters/NewLinePatternConverter.cs ---
@@ -72,6 +75,16 @@ internal sealed class NewLinePatternConverter :
LiteralPatternConverter, IOption
/// </remarks>
public void ActivateOptions()
{
+#if NETSTANDARD1_3
+ if
(CultureInfo.InvariantCulture.CompareInfo.Compare(Option, "DOS",
CompareOptions.IgnoreCase) == 0)
+ {
+ Option = "\r\n";
+ }
+ else if
(CultureInfo.InvariantCulture.CompareInfo.Compare(Option, "UNIX",
CompareOptions.IgnoreCase) == 0)
--- End diff --
@chlowell, do you think it's a good idea to instead of dogfooding
`string.Compare(strA, strB, InvariantCulture) == 0` pattern with `CultureInfo`
comparer, use common denominator `strA.ToUpperInvariant() ==
strB.ToUpperInvariant()` and remove the preprocessor all over the place as part
of this PR? IMO, this will clean up quite a bit. If you want, I can send a PR
to your `log4net-core-pcl` branch, then you would just need to update the JIRA
patch. :)
> Is .NET Core, will be supported in the near future, or not
> ----------------------------------------------------------
>
> Key: LOG4NET-467
> URL: https://issues.apache.org/jira/browse/LOG4NET-467
> Project: Log4net
> Issue Type: New Feature
> Components: Core
> Affects Versions: 1.2.13
> Reporter: san kan
> Labels: features
> Attachments: LOG4NET-467.patch
>
>
> As you know, ms is moving heavily toward .Net core:
> https://github.com/dotnet/core
> so, is there a road map for making a version that supports it?
> and i noticed that log4net, has not been updated for 2 years.
> so is it maintained, or being forgotten?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
