Hi,

While cleaning up I'm wondering if we also should care about the naming convention of the class names and directory structure? If we should do it, this is the right time to do it.

I propose these changes in class names to align all names with eachother.

LoggerPatternLayout -> LoggerLayoutPattern
LoggerXmlLayout -> LoggerLayoutXml
LoggerDefaultRenderer -> LoggerRendererDefault
LoggerObjectRenderer -> LoggerRendererObject
LoggerPropertyConfigurator -> LoggerConfiguratorProperty
LoggerBasicConfigurator -> LoggerConfiguratorBasic
LoggerDOMConfigurator -> LoggerConfiguratorDOM
LoggerDenyAllFilter -> LoggerFilterDenyAll
LoggerLevelMatchFilter -> LoggerFilterLevelMatch
LoggerLevelRangeFilter -> LoggerFilterLevelRange
LoggerStringMatchFilter -> LoggerFilterStringMatch

We can also rename some folders:

varia -> filters
or -> renderers
xml -> configurators (and move all configurators here)

The "spi" folder only contains one interface. We could rename this folder to "core" i.e. and put all abstract classes, base classes and interfaces here.

Let me know what you think! Is it ok for you? Any objections? If you don't disagree I can apply this soon.

Knut

Reply via email to