Hi,

+1 on all!


> xml -> configurators (and move all configurators here)

In the config folder is just LoggerPropertyGetter/Setter. This should
be core (as ReflectionUtils) or in the configurators folder too.
LoggerPropertyGetter doesn't provide anything, should be removed.
LoggerPropertySetter could be renamed to ReflectionUtils (cause its
not only for configurations imho)

> The "spi" folder only contains one interface. We could rename this folder to
> "core" i.e. and put all abstract classes, base classes and interfaces here.

Why not have all core classes in the "root" folder src/main/php/* ?

> Let me know what you think! Is it ok for you? Any objections? If you don't
> disagree I can apply this soon.

Cool :-)
Christian

Reply via email to