[
https://issues.apache.org/jira/browse/LOG4PHP-174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13229324#comment-13229324
]
Christoph Dorn commented on LOG4PHP-174:
----------------------------------------
Hi, I am the author of FirePHP.
It's great to see someone warp FirePHP 1.0 and specifically the insight API!
The way it is done in this patch is the recommended approach but it could be
improved slightly.
Don't require 'FirePHP/Init.php' at the top of the page and check if the
'FirePHP' class exists with the "to" method instead. If it does use it. If it
does not don't send anything to FirePHP.
This way there is no dependency in the log4php lib and things will
automatically work if FirePHP 1.0 is installed and configured for all vhosts on
a server for instance. The FirePHP/Insight lib is intended to wrap the entire
application and should be loaded before anything else.
You could also ship an implementation of the old protocol (as linked (Monolog)
above) as a fallback or optional transport. I would not try and bundle or
re-implement the new protocol as that is the purpose of the Insight library
which will be evolving.
FYI, In time the FirePHP extension will get support for the Insight API as well
and the whole setup procedure will be simplified (for FirePHP extension and
DeveloperCompanion) but if you simply wrap the Insight API as you have done
nothing will change for you.
> Firephp appender logs to Firebug console.
> -----------------------------------------
>
> Key: LOG4PHP-174
> URL: https://issues.apache.org/jira/browse/LOG4PHP-174
> Project: Log4php
> Issue Type: Improvement
> Components: Code
> Affects Versions: 2.3.0
> Environment: Mozilla Firefox, possibly Google Chrome
> Reporter: Bruce Ingalls
> Labels: features, patch
> Attachments: log4diff.tar.bz2
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> I followed the guidelines at
> http://logging.apache.org/log4php/contributingpatches.html
> However, Jira does not seem to have a way to upload files, such as the
> Appender I'd like to donate to this project.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
