[
http://jira.qos.ch/browse/LBCORE-128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=11567#action_11567
]
Joern Huxhorn commented on LBCORE-128:
--------------------------------------
I'm currently checking out the code but I'm not done yet.
One thing that I'm missing is some info about whether I'm handling a fresh,
i.e. empty file, or whether I'm appending to an existing one.
I'd need that info because I'd have to write a file header in
init(OutputStream) in case of an new file while I'd have to do nothing while
appending to an existing one.
(The message in encoderInit still wrong, btw. It says "Failed to write footer
for appender named [".)
Beside that everything looks fine, so far.
I'll implement some encoder in the near future but, at the moment, it would
only work if 'append' is false, creating a broken file otherwise.
Cheers,
Jörn.
> Please support implementation of binary log files in
> RollingFileAppender/FileAppender
> -------------------------------------------------------------------------------------
>
> Key: LBCORE-128
> URL: http://jira.qos.ch/browse/LBCORE-128
> Project: logback-core
> Issue Type: Improvement
> Components: Appender
> Affects Versions: 0.9.17
> Reporter: Joern Huxhorn
> Assignee: Ceki Gulcu
>
> This was discussed briefly at
> http://marc.info/?l=logback-dev&m=124905434331308&w=2 and I forgot to file a
> ticket about this.
> Currently, RandomFileAppender => FileAppender => WriterAppender is using the
> following method in WriterAppender to actually write the data:
> protected void writerWrite(String s, boolean flush) throws IOException
> Please add an additional method like
> protected void writerWrite(byte[] bytes, boolean flush) throws IOException
> to write to the underlying stream directly.
> writerWrite(String, boolean) could call that method after performing the
> transformation internally, making this change transparent for the rest of the
> implementation.
> Using a binary format for logfiles could have tremendous performance impact
> as can be seen here:
> http://sourceforge.net/apps/trac/lilith/wiki/SerializationPerformance
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.qos.ch/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
_______________________________________________
logback-dev mailing list
[email protected]
http://qos.ch/mailman/listinfo/logback-dev
