[ 
http://jira.qos.ch/browse/LBCORE-128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=11582#action_11582
 ] 

Joern Huxhorn commented on LBCORE-128:
--------------------------------------

Hi Ceki,

I've successfully implemented a first version of encoders for both classic and 
access events using your encoder branch.
http://github.com/huxi/lilith/commit/1fa631dd006a965f6f727e286a7469071116366b

As expected, appending to an already existing file doesn't work and will break 
the file.
Some info in init() woud be necessary to determine if the stream is a fresh 
stream or a reused/appended one.

Thank you very much for your work so far!

> Please support implementation of binary log files in 
> RollingFileAppender/FileAppender
> -------------------------------------------------------------------------------------
>
>                 Key: LBCORE-128
>                 URL: http://jira.qos.ch/browse/LBCORE-128
>             Project: logback-core
>          Issue Type: Improvement
>          Components: Appender
>    Affects Versions: 0.9.17
>            Reporter: Joern Huxhorn
>            Assignee: Ceki Gulcu
>
> This was discussed briefly at 
> http://marc.info/?l=logback-dev&m=124905434331308&w=2 and I forgot to file a 
> ticket about this.
> Currently, RandomFileAppender => FileAppender => WriterAppender is using the 
> following method in WriterAppender to actually write the data:
> protected void writerWrite(String s, boolean flush) throws IOException
> Please add an additional method like
> protected void writerWrite(byte[] bytes, boolean flush) throws IOException
> to write to the underlying stream directly.
> writerWrite(String, boolean) could call that method after performing the 
> transformation internally, making this change transparent for the rest of the 
> implementation.
> Using a binary format for logfiles could have tremendous performance impact 
> as can be seen here: 
> http://sourceforge.net/apps/trac/lilith/wiki/SerializationPerformance

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.qos.ch/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        
_______________________________________________
logback-dev mailing list
[email protected]
http://qos.ch/mailman/listinfo/logback-dev

Reply via email to