> a) a two reasons why this module should never have been written, and 1. It's redundant, other modules do this already. 2. MM DD YY is an evil date format, and should be abolished in favour of DD MM YY which is more sensible. > b) as many flaws as possible in the implementation. No use strict Only requires 5.000 but makes use of 'our' keyword, which requires, err, 5.006? Doesn't localise variables in subs Appallingly long string of elsifs Doesn't use localtime when he should does $foo = $array[4]; without commenting what @array might contain In case of error, returns an error string consisting of the helpful message 'Error'. Oh it's dreadful. We need quality control on CPAN before more of this gets through. > Dave... > [with his nasty, bitchy head on] >
- Re: Pointless, Badly-Written Module. Mark Fowler
- Re: Pointless, Badly-Written Module. Dave Cross
- Re: Pointless, Badly-Written Module. Roger Burton West
- Re: Pointless, Badly-Written Module. Robin Houston
- Re: Pointless, Badly-Written Module. Leon Brocard
- Re: Pointless, Badly-Written Module. Robin Houston
- Re: Pointless, Badly-Written Module. Chris Devers
- Re: Pointless, Badly-Written Modul... Roger Burton West
- Re: Pointless, Badly-Written Module. Matthew Robinson
- Re: Pointless, Badly-Written Module. Dave Cross
- RE: Pointless, Badly-Written Module. Jonathan Peterson
- RE: Pointless, Badly-Written Module. Mark Fowler
- Re: Pointless, Badly-Written Module. David Cantrell
- Re: Pointless, Badly-Written Module. David H. Adler
- Re: Pointless, Badly-Written Module. Marty Pauley
- Balding Badly-Coiffed Hackers (was... Jonathan Stowe
- Balding Badly-Coiffed Hackers (was... Jonathan Stowe
- Re: Balding Badly-Coiffed Hack... David H. Adler
- RE: Pointless, Badly-Written Module. Simon Wilcox
- Re: Pointless, Badly-Written Module. Alex Page
- Re: Pointless, Badly-Written Module. Dave Cross