On Tue, 20 Mar 2001, Dave Cross wrote:
>
> Take a look at this <http://search.cpan.org/search?dist=Date-MMDDYY>.
>
> Now give me:
>
> a) a two reasons why this module should never have been written, and
1) I'm English. MMDDYY makes not sense. Maybe that's just a gripe about
the name.
2) Time::Object rocks.
> b) as many flaws as possible in the implementation.
no 'use strict'
should use prototypes to force scalar context on the string passed (but
see below for gripe)
Spliting up the string representation of a time is a bad thing and why not
just use the array format of gmtime/localtime.
no 'my @format'
no 'my $delem'
no 'my @time_array'
The whole string with delimeters thing is silly and just let people pass
each formating thing in @_ directly.
no 'my @final_date' # but with an undef!
does not die, or return undef, or do anything sensible with an error, just
returns 'Error'.
--
print "\n",map{my$a="\n"if(length$_>6);' 'x(36-length($_)/2)."$_\n$a"} (
Name => 'Mark Fowler', Title => 'Technology Developer' ,
Firm => 'Profero Ltd', Web => 'http://www.profero.com/' ,
Email => '[EMAIL PROTECTED]', Phone => '+44 (0) 20 7700 9960' )
