Issue #206 has been updated by Rémy-Christophe Schermesser.
I have some comments on the source code. We prefer to have brackets everywhere even for single-lined if. So can you add them ? You use the method keySet on the Map matchingEntries. The method entrySet is quicker, and why not put a nice foreach instead of a while on an iterator ? Why did code the class as a factory ? I do not thnik this is useful, because I think it will be used in JavaScript. At last, where is the unit test ? ;) ---------------------------------------- Feature #206: Method to determine the next available digital identifier for a given attribute in a directory http://tools.lsc-project.org/issues/show/206 Author: Stéfanie Duprey Status: New Priority: Normal Assigned to: Sébastien Bahloul Category: Core Target version: 1.3 branch Add a method to determine the next available digital identifier for a given attribute in a directory. -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://tools.lsc-project.org/my/account
_______________________________________________________________ Ldap Synchronization Connector (LSC) - http://lsc-project.org lsc-dev mailing list [email protected] http://lists.lsc-project.org/listinfo/lsc-dev
