Issue #206 has been updated by Stéfanie Duprey. File NextIntAttributeValueFinder.java added File NextIntAttributeValueFinderTest.java added File testNextIntAttribute_5438entries.ldif added
Rémy-Christophe Schermesser wrote: > I have some comments on the source code. Thanks > > We prefer to have brackets everywhere even for single-lined if. So can you > add them ? Done (see attachment) > You use the method keySet on the Map matchingEntries. The method entrySet is > quicker, and why not put a nice foreach instead of a while on an iterator ? Ok > > Why did code the class as a factory ? I do not thnik this is useful, because > I think it will be used in JavaScript. I code the class as a singleton not a factory, because we should not have more than one instance of this class running to avoid two simultaneous calls to the method getNextValue. I didn't use a static method because there is some state stored. How would you have done this ? > > At last, where is the unit test ? ;) I give you some and the ldif corresponding, but I need some help to know how to tell the unit test to load the ldif before try the assert (and how to empty the directory for the other test). Could you help me doing this please ? Thanks a lot for your help. ---------------------------------------- Feature #206: Method to determine the next available digital identifier for a given attribute in a directory http://tools.lsc-project.org/issues/show/206 Author: Stéfanie Duprey Status: New Priority: Normal Assigned to: Sébastien Bahloul Category: Core Target version: 1.3 branch Add a method to determine the next available digital identifier for a given attribute in a directory. -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://tools.lsc-project.org/my/account
_______________________________________________________________ Ldap Synchronization Connector (LSC) - http://lsc-project.org lsc-dev mailing list [email protected] http://lists.lsc-project.org/listinfo/lsc-dev
