Hi Tom, Thanks for the review. Version -20 includes the fixes. Please see my answers below inline.
Thanks, Yingzhen On Thu, Jan 18, 2024 at 4:13 AM tom petch <[email protected]> wrote: > This I-D changes the names of some bits in the identity cf RFC8667. I > think that the description clause should then give the mapping to the > RFC8667 name. I see this for > lo-bit > pe-bit > af-bit > These may be excellent names but they are not what RFC8667 specifies! > [Yingzhen]: Unfortunately YANG doesn't allow the same identity name with different bases. For example, l-flag is defined with base "prefix-sid-flag", so we can't define 'l-flag" again with base "adj-sid-flag", so I changed it to "lo-flag". > > As the YANG doctor review says, the description should reference RFC and > section thereof for all identity such as r-bit. > [Yingzhen]: fixed. > > The I-D refences > RFC8102 > draft-ietf-rtgwg-segment-routing-ti-lfa > > which need adding to the I-D References > > [Yingzhen]: Added. > Perhaps in the YANG augment > OLD > "This augments ISIS protocol configuration > with segment routing."; > NEW > "This augments ISIS protocol configuration > with segment routing for the MPLS data plane."; > > [Yingzhen]: fixed. same for OSPF. > Tom Petch > > > ________________________________________ > From: Lsr <[email protected]> on behalf of [email protected] < > [email protected]> > Sent: 31 December 2023 06:30 > To: [email protected] > Cc: [email protected] > Subject: [Lsr] I-D Action: draft-ietf-isis-sr-yang-19.txt > > Internet-Draft draft-ietf-isis-sr-yang-19.txt is now available. It is a > work > item of the Link State Routing (LSR) WG of the IETF. > > Title: A YANG Data Model for IS-IS Segment Routing for the MPLS Data > Plane > Authors: Stephane Litkowski > Yingzhen Qu > Pushpasis Sarkar > Ing-Wher Chen > Jeff Tantsura > Name: draft-ietf-isis-sr-yang-19.txt > Pages: 31 > Dates: 2023-12-30 > > Abstract: > > This document defines a YANG data module that can be used to > configure and manage IS-IS Segment Routing for MPLS data plane. > > The IETF datatracker status page for this Internet-Draft is: > https://datatracker.ietf.org/doc/draft-ietf-isis-sr-yang/ > > There is also an HTML version available at: > https://www.ietf.org/archive/id/draft-ietf-isis-sr-yang-19.html > > A diff from the previous version is available at: > https://author-tools.ietf.org/iddiff?url2=draft-ietf-isis-sr-yang-19 > > Internet-Drafts are also available by rsync at: > rsync.ietf.org::internet-drafts > > > _______________________________________________ > Lsr mailing list > [email protected] > https://www.ietf.org/mailman/listinfo/lsr >
_______________________________________________ Lsr mailing list [email protected] https://www.ietf.org/mailman/listinfo/lsr
