Subrata/Amit
  I am attaching the Makefile.
Regarding the setting up the environment for executing the test, searching for EXT4 partition may not be suitable
        As the found partition may not be set up to execute the test.

So options I am thinking are:--
1) Set up the environment through LTP commands
  -> Display appropriate message if fallocate is not supported
2) Set the execution path through command line
  -> Display appropriate message if fallocate is not supported

Let me know if you have more ideas

Thanks
Sharyathi
Amit K Arora wrote:

Sharyathi,

You may also provide a command line option for the user to be able to specify the test path. And then check if this path is on a ext4 file system or not. And if there is no path provided, the default behavior may be to look for a ext4 partition, create a temp directory and execute your test in it; as Subrata has suggested.

Regards,
Amit Arora


*Subrata Modak <[EMAIL PROTECTED]>*

12/26/07 12:36 PM
Please respond to
[EMAIL PROTECTED]


        
To
        [EMAIL PROTECTED]
cc
        [email protected], Amit K Arora/India/[EMAIL PROTECTED]
Subject
        Re: [LTP] LTP tests for fallocate


        





On Tue, 2007-12-25 at 01:17 +0530, Sharyathi Nagesh wrote:
 > Hi
 >    I am attaching a test cases written for testing fallocate() system
 > call. Please go through the tests and let us know of your opinion.
 >    A few points I wanted to put forth.
 > o It needs to be executed from a folder that has EXT4 partition.
 >                  else it will come out with error

Ok, why don“t we/you search for the EXT4 file system before starting
testing from inside your test case (in this from each of the 3 test
cases) to find out the existence of EXT4 file system, if any in that
system. Run the tests only if it exists, else exit with appropriate
message. Moreover, try to create a temp directory in that file system,
if at all it exists, and then go ahead with the test.
And Also the Makefile for this? Send me a Patch which would add up all
the test cases as well as the Makefile for them, after all the issues
are resolved

--Subrata

> o __NR_FALLOCATE needs to be declared under > include/linux_syscall_numbers.h
 > Some of the architecture specific values:
 > x86                                   324
 > x86_64                                   324
 > ia64                                  1303
 > s390                                  314
 >
 > Thanks
 > Yeehaw
 > -------------------------------------------------------------------------
 > This SF.net email is sponsored by: Microsoft
 > Defy all challenges. Microsoft(R) Visual Studio 2005.
 > http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
> _______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list



#
#  Copyright (c) International Business Machines  Corp., 2001
#
#  This program is free software;  you can redistribute it and/or modify
#  it under the terms of the GNU General Public License as published by
#  the Free Software Foundation; either version 2 of the License, or
#  (at your option) any later version.
#
#  This program is distributed in the hope that it will be useful,
#  but WITHOUT ANY WARRANTY;  without even the implied warranty of
#  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See
#  the GNU General Public License for more details.
#
#  You should have received a copy of the GNU General Public License
#  along with this program;  if not, write to the Free Software
#  Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
#

CFLAGS += -I../../../../include -Wall
LDLIBS += -L../../../../lib -lltp

SRCS    = $(wildcard *.c)
TARGETS = $(patsubst %.c,%,$(SRCS))

all: $(TARGETS)

install:
        @set -e; for i in $(TARGETS); do ln -f $$i ../../../bin/$$i ; done

clean:
        rm -f $(TARGETS)
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

Reply via email to