On Thu, 2008-01-03 at 10:04 +0530, Sharyathi Nagesh wrote: > Nate Straz wrote: > > > > On Tue, 2007-12-25 at 01:17 +0530, Sharyathi Nagesh wrote: > >> Hi > >> I am attaching a test cases written for testing fallocate() system > >> call. Please go through the tests and let us know of your opinion. > >> A few points I wanted to put forth. > >> o It needs to be executed from a folder that has EXT4 partition. > >> else it will come out with error > > > > Other file systems may implement fallocate(), don't restrict this to > > EXT4. You should be able to detect if the file system on which the test > > runs does not support the operation and return a TCONF test status. > > I would suggest using option 2, allow a command line option. > > > > Nate > > Thanks for giving feed back, we also discussed here with Amit and Aneesh > and after that we thought giving specific argument to the test, > specifying folder to run test, may not be appropriate as it is executed > as part of ltp-runall test. Instead we thought to handle ENOSYS (system > call not implemented) as test success. > > Let me know what you think of it. I can go ahead and complete it than.
I think we should then go ahead with this idea. Please send me when you are complete with the final patch. Thanks for writing the fallocate() test cases. Hope that you will keep contributing to LTP. Thanks-- Subrata > Thanks > Sharyathi ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
