Thanks. I will test this again and get back to you. Regards-- Subrata
On Mon, 2008-07-28 at 13:25 -0300, Ramon de Carvalho Valle wrote: > Hi Subrata, > > According to robust futexes documentation, at the time of writing, only > i386 and x86_64 are supported, other architectures doesn't have these > system calls yet. The attached patch contains the testcases with > suggested modifications. > > Best regards, > > > On Sat, 2008-07-26 at 19:32 +0530, Subrata Modak wrote: > > Michael, > > > > Would you like to review Ramon´s test cases on get_robust_list() and > > set_robust_list() ? > > > > Hi Ramon, > > > > Here are my small observations of the patch: > > > > 1) You have disabled compiling the testcases: get_robust_list01.c and > > set_robust01.c through ltp/testcases/kernel/syscalls/Makefile. I am not > > sure what purpose does it serve in adding the syscall tests when you do > > not want to compile/install/run them. And also a entry for both > > get_robust_list01 and set_robust list01 is missing from > > runtest/syscalls. I hope in your next patch you will compile this by > > deafult and also include an entry to run them along with other syscalls. > > > > I enabled the test cases to build/install and run, and following are my > > observations when i ran them across some architectures: > > > > 1) Linux 2.6.18-92.el5 #1 SMP Tue Apr 29 13:16:12 EDT 2008 i686 i686 > > i386 GNU/Linux > > BUILD=PASS, INSTALL=PASS, RUN=PASS > > > > 2) Linux 2.6.18-91.el5 #1 SMP Tue Apr 22 17:43:57 EDT 2008 x86_64 x86_64 > > x86_64 GNU/Linux > > BUILD=PASS, INSTALL=PASS, RUN=PASS > > > > 3) Linux 2.6.18-91.el5 #1 SMP Tue Apr 22 17:48:59 EDT 2008 ppc64 ppc64 > > ppc64 GNU/Linux > > BUILD=PASS, INSTALL=PASS, RUN=PASS > > > > > > 4) Linux 2.6.25-gcov-nomodconfig-smp #1 SMP Thu Jun 12 06:29:27 EDT 2008 > > i686 i686 i386 GNU/Linux > > BUILD=FAIL, > > 5) Linux 2.6.9-42.ELsmp #1 SMP Wed Jul 12 23:32:02 EDT 2006 x86_64 > > x86_64 x86_64 GNU/Linux > > BUILD=FAIL > > 6) Linux 2.6.9-42.EL #1 SMP Wed Jul 12 23:22:51 EDT 2006 ppc64 ppc64 > > ppc64 GNU/Linux > > BUILD=FAIL > > 7) Linux 2.6.16.21-0.8-default #1 SMP Mon Jul 3 18:25:39 UTC 2006 ia64 > > ia64 ia64 GNU/Linux > > BUILD=FAIL > > > > > > Following are the error messages when they failed: > > > > cc -Wall -I../../include -g -Wall -I../../../../include -Wall > > get_robust_list01.c -L../../../../lib -lltp -o get_robust_list01 > > get_robust_list01.c: In function ‘main’: > > get_robust_list01.c:75: error: storage size of ‘head’ isn’t known > > get_robust_list01.c:87: error: invalid application of ‘sizeof’ to > > incomplete type ‘struct robust_list_head’ > > get_robust_list01.c:100: error: ‘__NR_get_robust_list’ undeclared (first > > use in this function) > > get_robust_list01.c:100: error: (Each undeclared identifier is reported > > only once > > get_robust_list01.c:100: error: for each function it appears in.) > > get_robust_list01.c:75: warning: unused variable ‘head’ > > make[4]: *** [get_robust_list01] Error 1 > > > > > > cc -Wall -I../../include -g -Wall -I../../../../include -Wall > > set_robust_list01.c -L../../../../lib -lltp -o set_robust_list01 > > set_robust_list01.c: In function ‘main’: > > set_robust_list01.c:75: error: storage size of ‘head’ isn’t known > > set_robust_list01.c:87: error: invalid application of ‘sizeof’ to > > incomplete type ‘struct robust_list_head’ > > set_robust_list01.c:97: error: ‘__NR_set_robust_list’ undeclared (first > > use in this function) > > set_robust_list01.c:97: error: (Each undeclared identifier is reported > > only once > > set_robust_list01.c:97: error: for each function it appears in.) > > set_robust_list01.c:75: warning: unused variable ‘head’ > > make[4]: *** [set_robust_list01] Error 1 > > > > > > I think you need to include some code which handles stuff like > > header/library/support checking in the Makefile, so that it aborts > > compilation and hence install due to lack of this. > > > > But in all instances you should be able to showup proper message(s) to > > the user when your test cases is not compiled/installed, but is run > > (this will definitely happen when executing runtest/syscalls). You may > > want to see the following thread how Vijay has handled it in his > > move_pages() syscall tests. > > > > Hope to see an updated patch from you soon. > > > > Regards-- > > Subrata > > > > -------- Forwarded Message -------- > > From: Ramon de Carvalho Valle <[EMAIL PROTECTED]> > > Reply-To: [EMAIL PROTECTED] > > To: [email protected] > > Subject: [LTP] [PATCH] New testcases for get_robust_list and > > set_robust_list system calls > > Date: Fri, 25 Jul 2008 16:23:56 -0300 > > > > Hi, > > > > The attached patch contains new testcases for get_robust_list and > > set_robust_list system calls. > > > > Best regards, > > > > > > ------------------------------------------------------------------------- > > This SF.Net email is sponsored by the Moblin Your Move Developer's challenge > > Build the coolest Linux based applications with Moblin SDK & win great > > prizes > > Grand prize is a trip for two to an Open Source event anywhere in the world > > http://moblin-contest.org/redirect.php?banner_id=100&url=/ > > _______________________________________________ Ltp-list mailing list > > [email protected] > > https://lists.sourceforge.net/lists/listinfo/ltp-list ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
